feat: remove passThroughFeedback

src/app/controllers/admin-forms.server.controller.js

@@ -49,29 +49,6 @@ function makeModule(connection) {
       }
       return next()
     },
-    /**
-     * Submit feedback when previewing forms
-     * Preview feedback is not stored
-     * @param  {Object} req - Express request object
-     * @param  {Object} res - Express response object
-     */
-    passThroughFeedback: function (req, res) {
-      if (
-        !req.params ||
-        !('formId' in req.params) ||
-        !req.body ||
-        !('rating' in req.body) ||
-        !('comment' in req.body)
-      ) {
-        return res
-          .status(StatusCodes.BAD_REQUEST)
-          .json({ message: 'Form feedback data not passed in' })
-      } else {
-        return res
-          .status(StatusCodes.OK)
-          .json({ message: 'Successfully received feedback' })
-      }
-    },
     /**
      * Pass through save new Submission object to db
      * Simply create and pass forward a submissions object w/o saving to db

src/app/routes/admin-forms.server.routes.js

@@ -327,22 +327,9 @@ module.exports = function (app) {
    * @returns {FeedbackResponse.model} 200 - form feedback was saved
    * @security OTP
    */
-  /**
-   * On preview, mock sending of feedback
-   * @route POST /{formId}/adminform/feedback
-   * @group forms - endpoints to serve forms
-   * @param {string} formId.path.required - the form id
-   * @param {Feedback.model} feedback.body.required - the user's feedback
-   * @consumes application/json
-   * @produces application/json
-   * @returns {string} 400 - form feedback was malformed
-   * @returns {string} 200 - form feedback was received
-   */
-
   app
     .route('/:formId([a-fA-F0-9]{24})/adminform/feedback')
     .get(withUserAuthentication, AdminFormController.handleGetFormFeedbacks)
-    .post(authActiveForm(PermissionLevel.Read), adminForms.passThroughFeedback)
 
   /**
    * Count the number of feedback for a form

src/public/modules/forms/services/form-feedback.client.factory.js

@@ -33,19 +33,20 @@ function FormFeedback($q, $http) {
   const feedbackAdminUrl = '/:formId/adminform/feedback'
   let feedbackService = {
     postFeedback: function (params, body) {
-      let resUrl = fixParamsToUrl(
-        params,
-        body.isPreview ? feedbackAdminUrl : resourceUrl,
-      )
       let deferred = $q.defer()
-      $http.post(resUrl, body).then(
-        function () {
-          deferred.resolve('Successfully posted feedback.')
-        },
-        function (_errorResponse) {
-          deferred.reject('Failed to post feedback.')
-        },
-      )
+      if (body.isPreview) {
+        deferred.resolve('Successfully posted feedback.')
+      } else {
+        let resUrl = fixParamsToUrl(params, resourceUrl)
+        $http.post(resUrl, body).then(
+          function () {
+            deferred.resolve('Successfully posted feedback.')
+          },
+          function (_errorResponse) {
+            deferred.reject('Failed to post feedback.')
+          },
+        )
+      }
       return deferred.promise
     },
     getFeedback: function (params) {