Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Expand test cases for mobile number validator to cover signature validation #1349

Merged
merged 1 commit into from
Mar 15, 2021
Merged

test: Expand test cases for mobile number validator to cover signature validation #1349

merged 1 commit into from
Mar 15, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Mar 11, 2021

Problem

Closes #1171

Solution

  • Ports over jasmine tests to jest tests for mobile number validator
  • Adds test for mobile number signature validation

@liangyuanruo liangyuanruo changed the title chore: Expand test cases for mobile number validator to cover signature validation test: Expand test cases for mobile number validator to cover signature validation Mar 15, 2021
@liangyuanruo liangyuanruo merged commit 1083aa1 into develop Mar 15, 2021
@liangyuanruo liangyuanruo deleted the test/mobile-number-signature branch March 15, 2021 05:05
@mantariksh mantariksh mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand test cases for mobile number validator to cover signature validation
2 participants
@tshuli @liangyuanruo