-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a limit for the number of MyInfo fields that can be added #1664
Conversation
src/public/modules/forms/admin/directiveViews/edit-form.client.view.html
Outdated
Show resolved
Hide resolved
….view.html Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
src/public/modules/forms/admin/directiveViews/edit-form.client.view.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @frankchn! this looks good, but I'll need to write and run a database query first to check that there aren't already forms with >30 MyInfo fields. if the current database state checks out then I'll approve and merge this. pending last comment below
Update on behalf on @mantariksh - there aren't any such forms, so the PR is safe. |
Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one remaining bug, otherwise looks good!
src/public/modules/forms/admin/directiveViews/edit-form.client.view.html
Outdated
Show resolved
Hide resolved
….view.html Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Problem
MyInfo fields must be limited to 30 per form on Email mode to comply with PII guidelines. In exchange, we get access to all fields.
Closes #1305
Solution
Adds limits and validators to the appropriate places to limit MyInfo fields to 30.
Screenshots
Tests