refactor(auth.client): (1) extract email validation and send login otp flow to Typescript #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better fit API prefix
not needed, may interfere with React migration. Should just handle it in the caller # Conflicts: # src/public/modules/users/controllers/authentication.client.controller.js # src/public/services/AuthService.ts
This was referenced Jun 7, 2021
|
lgtm! cool usage of the opaque type! |
mantariksh
reviewed
Jun 7, 2021
src/public/modules/users/controllers/authentication.client.controller.js
Outdated
Show resolved
Hide resolved
|
Ready for re-review |
tshuli
reviewed
Jun 9, 2021
Co-authored-by: tshuli <63710093+tshuli@users.noreply.github.com>
tshuli
reviewed
Jun 9, 2021
tshuli
reviewed
Jun 9, 2021
tshuli
reviewed
Jun 9, 2021
mantariksh
approved these changes
Jun 9, 2021
3 tasks
19 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is part 1 of migrating auth.client.js to Typescript. This PR extracts out the first two functions
checkIsEmailAllowedfor verifying whether email domain is whitelisted, andsendLoginOtpfor sending the login OTPRelated to #2057
Solution
Breaking Changes
Features:
AuthServicefile containing the first two service functions for admin login flowauth.client.service.jsfunction calls with newAuthServicefunctions.Tests
Unit tests have been added for the new
AuthServicefunctions.Manual Tests
(Verification of OTP not tested because not in this PR)