refactor(auth.client): (3) extract fetch user service function to Typescript #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
mantariksh
reviewed
Jun 7, 2021
karrui
force-pushed
the
feat/authservice-fetch-user-ts
branch
from
5509987
to
f1e391a
Compare
|
Ready for re-review |
mantariksh
approved these changes
Jun 9, 2021
karrui
force-pushed
the
feat/authservice-verify-userservice-ts
branch
from
5a03fa6
to
aa596c9
Compare
karrui
force-pushed
the
feat/authservice-fetch-user-ts
branch
from
6ee3605
to
6a90837
Compare
Base automatically changed from
feat/authservice-verify-userservice-ts
to
feat/authsvc-ts-base
June 10, 2021 05:10
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain:
sendOtp<---verifyOtp<--fetchUser(you are here)Problem
This PR is part 3 of migrating auth.client.js to Typescript. This PR extracts out the fetch user function
Related to #2057
Solution
Breaking Changes
Features:
Tests
Unit tests have been written for
UserService.fetchUserManual tests