feat: add and call v3 API for retrieving individual admin form #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and can be often wrong, and the real route is already lines away
this allows us to eventually deprecate the old GET /adminform endpoints (and its ilk)
mantariksh
approved these changes
Jun 9, 2021
Merged
mantariksh
added a commit
that referenced
this pull request
Jun 15, 2021
* Revert "refactor: simplify isUenValid logic (#2156)" This reverts commit 8f0eda6. * Revert "feat: add UEN field (#2100)" This reverts commit 35eeeaf. * Revert "feat: add and call v3 API for retrieving individual admin form (#2113)" This reverts commit e55e1a9. * Revert "chore: remove redundant ValidationOption object properties for short text, long text and number fields (#2040)" This reverts commit 95b6297. * Revert "feat: Add webhook support for storage mode attachments (#1713)" This reverts commit 332d3ce.
mantariksh
pushed a commit
that referenced
this pull request
Jun 17, 2021
* feat: add v3 API for retrieving admin form by id * feat: remove `@routes` JSDoc line as they do not add info and can be often wrong, and the real route is already lines away * feat(AdminViewFormService): call v3 API to retrieve admin form this allows us to eventually deprecate the old GET /adminform endpoints (and its ilk)
2 tasks
mantariksh
added a commit
that referenced
this pull request
Jun 17, 2021
#2201) * feat: add v3 API for retrieving admin form by id * feat: remove `@routes` JSDoc line as they do not add info and can be often wrong, and the real route is already lines away * feat(AdminViewFormService): call v3 API to retrieve admin form this allows us to eventually deprecate the old GET /adminform endpoints (and its ilk) Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seems to have been missed out when duplicating the current APIs into their
/api/v3counterparts. This PR adds the new endpoint, calls the new endpoint, and adds missing tests for the endpoint.Solution
Breaking Changes
Features:
Tests
New integration tests have been added for the new endpoint.
Manual test