refactor: simplify isUenValid logic #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
watch out! // Length 9
isUenValid('1 A') // true
isUenValid(' A') // true
isUenValid(' 1 A') // true
// Length 10
isUenValid(' 1+1 A') // true
isUenValid(' 0.1+0.1 A') // true
isUenValid('1 1A') // true
isUenValid('-1 1A') // true
|
Merged
mantariksh
added a commit
that referenced
this pull request
Jun 15, 2021
This reverts commit 8f0eda6.
mantariksh
added a commit
that referenced
this pull request
Jun 15, 2021
* Revert "refactor: simplify isUenValid logic (#2156)" This reverts commit 8f0eda6. * Revert "feat: add UEN field (#2100)" This reverts commit 35eeeaf. * Revert "feat: add and call v3 API for retrieving individual admin form (#2113)" This reverts commit e55e1a9. * Revert "chore: remove redundant ValidationOption object properties for short text, long text and number fields (#2040)" This reverts commit 95b6297. * Revert "feat: Add webhook support for storage mode attachments (#1713)" This reverts commit 332d3ce.
mantariksh
added a commit
that referenced
this pull request
Jun 17, 2021
* refactor: simplify isUenValid logic * fix: use stricter regex matching
mantariksh
added a commit
that referenced
this pull request
Jun 17, 2021
* feat: add UEN field (#2100) * add uen field in public frontend * add essential uen types * make sure uen field renders * replace isUenValid with isUenField * refactor: simplify isUenValid logic (#2156) * refactor: simplify isUenValid logic * fix: use stricter regex matching Co-authored-by: Aniruddha Adhikary (Ani) <aniruddha@adhikary.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the logic to validate UENs. Implementation can be cross-referenced against the docs.
Manual tests as per #2100.