feat(feature-manager): remove feature toggles from frontend #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Jun 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature manager, which allows features to be toggled on and off based on environment variables, was a premature optimisation which has not been useful for users and slows development work unnecessarily. It should be removed.
The frontend relies on the
/client/featuresAPI to determine which features to activate, and this reliance must be eliminated first so that the API can subsequently be removed in a backwards-compatible manner.Part of #1842
Solution
Remove all the frontend feature toggles as well as API calls to
/client/features.Breaking Changes