build: merge release v4.36.0 into master #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: [develop] Release 4.35.0
* fix(dev): fix server hot reloading * fix(dev): switch to localstack edge port * fix(dev): use default init method for localstack * docs: add explanation for AWS entrypoint
* fix(deps): bump helmet from 3.23.1 to 4.1.0 Bumps [helmet](https://github.com/helmetjs/helmet) from 3.23.1 to 4.1.0. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](helmetjs/helmet@v3.23.1...v4.1.0) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 2437e8dd442a3ef071617b2fe396b667145c5dd9) * chore: import nocache * fix: merge conflicts * fix: declare type of cspDirective * test: check that helmet sets the correct headers * fix: replace helmet.noCache with nocache * docs: explain why if statement is necessary for optional directives * chore: improve tests * chore: update styleSrc in tests * docs: link to helmetjs issue on falsey values * chore: shift mock implementations to beforeEach * refactor: use mockReturnValue instead of mockImplementation * chore: remove unnecessary mock function implementation which returns undefined * chore: simplify csp tests and make them stricter * chore: use beforeAll and clearAllMocks * refactor: mockReturnValue instead of mockImplementation * fix: set correct mockFeatureManager.props for !cspReportUri * refactor: shift cspCoreDirective constant up * chore: add tests for hsts * fix: use ContentSecurityPolicyOptions for type * refactor: filter for hsts middleware instead of using array index * chore: include param for expect mockHelmet.hsts to have been called Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com> * refactor: use find() instead of filter() * fix: set correct default value for secure * chore: rename test folder * chore: check that next() is called correctly by hstsMiddleware * chore: remove unnecessary mockReturnValue for mockHelmet.hsts Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Bumps [concurrently](https://github.com/kimmobrunfeldt/concurrently) from 3.6.1 to 5.3.0. - [Release notes](https://github.com/kimmobrunfeldt/concurrently/releases) - [Commits](kimmobrunfeldt/concurrently@3.6.1...v5.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [whatwg-fetch](https://github.com/github/fetch) from 3.0.0 to 3.4.1. - [Release notes](https://github.com/github/fetch/releases) - [Commits](JakeChampion/fetch@v3.0.0...v3.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [winston](https://github.com/winstonjs/winston) from 3.2.1 to 3.3.3. - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@3.2.1...v3.3.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): bump async from 1.5.2 to 3.2.0 Bumps [async](https://github.com/caolan/async) from 1.5.2 to 3.2.0. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md) - [Commits](caolan/async@v1.5.2...v3.2.0) Signed-off-by: dependabot[bot] <support@github.com> * fix(deps): uninstall async Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Needed for test environment to remove console log spam during tests
chore: [develop] release 4.35.1 hotfix
* chore: update travis.yml It will now install a pinned version of localstack and use the chrome addon instead of downloading from apt * chore: pin localstack version * chore: remove code related to localstack from travis.yml * build: re-enable e2e tests Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.2.11 to 10.4.0. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.2.11...v10.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 8.10.2 to 9.0.0. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](TypeStrong/ts-node@v8.10.2...v9.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.21.2 to 2.22.0. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.21.2...v2.22.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 7.8.1 to 7.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.8.1...v7.9.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): bump celebrate from 12.2.0 to 13.0.3 Bumps [celebrate](https://github.com/arb/celebrate) from 12.2.0 to 13.0.3. - [Release notes](https://github.com/arb/celebrate/releases) - [Commits](arb/celebrate@v12.2.0...v13.0.3) Signed-off-by: dependabot[bot] <support@github.com> * fix: update how error message is extracted from celebrate errors * feat: add return typing for errorHandlerMiddlewares * feat: remove unused error message interpolation from rebase Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
* fix: package.json & package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677 * fix: uninstall node-jose Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.0.0 to 24.0.2. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/master/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v24.0.0...v24.0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Filter Storage Mode Responses by Submission Id (updated 2020-09-13) * Update page design so that it is compatible with tablets and everything is on one row * Update CSS for iPad
* fix(deps): bump csv-parse from 4.10.1 to 4.12.0 Bumps [csv-parse](https://github.com/wdavidw/node-csv-parse) from 4.10.1 to 4.12.0. - [Release notes](https://github.com/wdavidw/node-csv-parse/releases) - [Changelog](https://github.com/adaltas/node-csv-parse/blob/master/CHANGELOG.md) - [Commits](adaltas/node-csv-parse@v4.10.1...v4.12.0) Signed-off-by: dependabot[bot] <support@github.com> * fix(deps-dev): move csv-parse to dev deps Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
* fix(deps): bump csv-string from 3.2.0 to 4.0.1 Bumps [csv-string](https://github.com/Inist-CNRS/node-csv-string) from 3.2.0 to 4.0.1. - [Release notes](https://github.com/Inist-CNRS/node-csv-string/releases) - [Commits](Inist-CNRS/node-csv-string@v3.2.0...v4.0.1) Signed-off-by: dependabot[bot] <support@github.com> * fix: use correctly imported stringify function Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
#332) * chore: add neverthrow package for explicit error handling * feat: add core DatabaseError * refactor(AuthService): rename and convert getAgencyWithEmail to Result * test(Auth): update tests to use new validateEmailDomain function * refactor(Auth): inline validate middleware into /checkuser endpoint * refactor(Auth): inline validate middleware into /sendotp endpoint * refactor(Auth): inline validate middleware into /verifyotp endpoint * refactor(Auth): remove unused auth.middlewares * refactor(Auth): remove unused imports/types after middleware removal * refactor(AuthService): use validateEmailDomain with ResultAsync return * refactor(AuthService): update createLoginOtp with ResultAsync return * refactor(AuthService): update verifyLoginOtp with ResultAsync return * fix: fix typo in logger action and remove unused imports * refactor(MailUtils): update generateLoginOtpHtml to return ResultAsync * refactor: update sendLoginOtp to return ResultAsync * refactor: update handleLoginSendOtp to chain ResultAsync calls * refactor(AuthController): update handleLoginVerifyOtp to chain * fix: remove unused imports and remove null assertion * feat: update comments and tests names to return error instead of throw * chore: update travis.yml It will now install a pinned version of localstack and use the chrome addon instead of downloading from apt * feat(AuthController): add explicit undefined check for req.session * refactor(UserService): update upsertUser function to ResultAsync * refactor(AuthController): use updated UserService#retrieveUser fn * feat(AuthController): add logging for unknown errors observed * refactor(Auth): extract mapRouteError into auth.utils file
* transfer code from old repo * some frontend changes * refactor authActiveForm to add admin permission * fix dropdown hidden in scroll * add tests * do not save form in schema transferOwner * add logging when failed verifyPersmission * fix logging; use Joi to validate email field * update test * update mobile css * remove PERMISSION.ADMIN and use PERMISSION.DELETE * fix lint * fix lint and rebase * update logging format * remove duplicated code * fix mobile view close button * refactor frontend * shift collaborator related code to collaborator-modal client controller * cannot add ownself as owner * refresh admin-form myform when collab myform changes * shift success message to the top * reset messages when saveCollabEmail * set spacing between email and dropdown to 10px * fix rebase * remove letter spacing; fix mobile add collab button * fix spelling; add typescript return type * Update error message * Fix positioning of cancel button * Fix sizing of avatar Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
* Update version of spcp client * Update package-lock Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
karrui
changed the title
mantariksh
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.