refactor: migrate SmsFactory to Typescript #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshuli
reviewed
Oct 1, 2020
tshuli
reviewed
Oct 1, 2020
arshadali172
reviewed
Oct 1, 2020
arshadali172
reviewed
Oct 1, 2020
arshadali172
reviewed
Oct 1, 2020
| import { sendAdminContactOtp, sendVerificationOtp } from './sms.service' | ||
| import { TwilioConfig } from './sms.types' | ||
|
|
||
| interface ISmsFactory { |
There was a problem hiding this comment.
move these to the types folder?
There was a problem hiding this comment.
I use typeof to get the types leh, I scared circular dependency :X
There was a problem hiding this comment.
Add a comment for future developers?
arshadali172
reviewed
Oct 1, 2020
arshadali172
reviewed
Oct 1, 2020
arshadali172
suggested changes
Oct 1, 2020
mantariksh
approved these changes
Oct 5, 2020
arshadali172
approved these changes
Oct 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR migrates SmsFactory to Typescript.
sms.*related files are also moved toservices/smsdirectory for better encapsulation.Related to #144
Note that this PR is purely for migrating sms factory and encapsulating related files under a service directory. There are still work to do regarding the sms module -- adding specific errors, adding neverthrow to the service functions, etc. This should be done in a separate PR.
Solution
Improvements:
SmsFactoryis migrated to Typescriptservices/sms/__tests__Tests
sms.servicehas now been rewritten in jest with Typescript with additional tests forsendAdminContactOtpsms.factory