Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v4.38.0 #414

Merged
merged 21 commits into from
Oct 6, 2020
Merged

build: release v4.38.0 #414

merged 21 commits into from
Oct 6, 2020

Conversation

arshadali172
Copy link
Contributor

@arshadali172 arshadali172 commented Oct 5, 2020 •
edited
Loading

New

  • feat: add trace to logs #405

Improvements

  • refactor: use validator's isEmail for validating email domains #386
  • refactor: migrate SmsFactory to Typescript #387
  • chore: add lint rule to prevent floating promises #404

Fixes

  • fix: only show exclamation in navbar if sms feature is enabled #383
  • fix: transfer form toastr #379
  • style: fix squished styling when user emails are too long #382
  • fix: invalid key reference in retrieving form submissions #385

Dependency upgrades

  • fix(deps): bump @sentry/browser from 5.22.3 to 5.24.2 #407
  • chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0 #375
  • fix(deps): bump twilio from 3.46.0 to 3.49.3 #367
  • chore(deps-dev): bump @types/node from 14.0.13 to 14.11.2 #374
  • fix(deps): bump nodemailer from 6.4.11 to 6.4.12 #399
  • fix(deps): bump multiparty from 4.2.1 to 4.2.2 #406
  • chore(deps-dev): bump eslint from 7.9.0 to 7.10.0 #401
  • fix(deps): bump aws-sdk from 2.734.0 to 2.763.0 #393
  • chore(deps-dev): bump @types/express from 4.17.6 to 4.17.8 #392
  • fix(deps): bump helmet from 4.1.0 to 4.1.1 #390

dependabot bot and others added 21 commits September 30, 2020 10:33
@dependabot
chore(deps-dev): bump @types/node from 14.0.13 to 14.11.2 (#374)
8878e6b 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.0.13 to 14.11.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump twilio from 3.46.0 to 3.49.3 (#367)
1a3c942 
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.46.0 to 3.49.3.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.46.0...3.49.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @karrui
chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0 (#375)
9c0cdcf 
* chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0

Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 8.0.0 to 8.3.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid)

Signed-off-by: dependabot[bot] <support@github.com>

* chore: trigger travis

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
@mantariksh
Merge pull request #384 from opengovsg/release-v4.37.0
3114683 
chore: merge release v4.37.0 back into develop
@karrui
fix: invalid key reference in retrieving form submissions (#385)
98d5345 
* fix: invalid key reference in retrieving form submissions
@karrui
Merge pull request #391 from opengovsg/release-v4.37.1
e332b91 
chore: merge Release v4.37.1 back into develop
@dependabot
fix(deps): bump helmet from 4.1.0 to 4.1.1 (#390)
c605cfe 
Bumps [helmet](https://github.com/helmetjs/helmet) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/helmetjs/helmet/releases)
- [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md)
- [Commits](helmetjs/helmet@v4.1.0...v4.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/express from 4.17.6 to 4.17.8 (#392)
61b7d8e 
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.6 to 4.17.8.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.734.0 to 2.763.0 (#393)
a74cbc2 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.734.0 to 2.763.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.734.0...v2.763.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui
style: fix squished styling when user emails are too long (#382)
39e5aa7
@jia1
refactor: use validator's isEmail for validating email domains (#386)
e59ea2d 
* refactor: use validator's isEmail for validating email domains (prepend email domains with 'bob')

* refactor: extract validation function into shared/util and apply validation function to directive too

* fix: fix import path

* fix: use relative path for import

* docs: explain why we need to prepend "bob" to email domains during validation

* refactor: add typing to createEmailFieldSchema instead of EmailFieldSchema

* fix: use correct relative path to shared/util for require call
@dependabot
chore(deps-dev): bump eslint from 7.9.0 to 7.10.0 (#401)
551ea43 
Bumps [eslint](https://github.com/eslint/eslint) from 7.9.0 to 7.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.9.0...v7.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump multiparty from 4.2.1 to 4.2.2 (#406)
3d2ba0c 
Bumps [multiparty](https://github.com/pillarjs/multiparty) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/pillarjs/multiparty/releases)
- [Changelog](https://github.com/pillarjs/multiparty/blob/master/HISTORY.md)
- [Commits](pillarjs/multiparty@4.2.1...4.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump nodemailer from 6.4.11 to 6.4.12 (#399)
cf6d4b3 
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.4.11 to 6.4.12.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.4.11...v6.4.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui
fix: only show exclamation in navbar if sms feature is enabled (#383)
c46c3b3
@dependabot
fix(deps): bump @sentry/browser from 5.22.3 to 5.24.2 (#407)
57862e9 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.22.3 to 5.24.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@5.22.3...5.24.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@awhdesmond
fix: transfer form toastr (#379)
965f2a9 
* use toastr to show error and success messages

* Add full stops

Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
@karrui
refactor: migrate SmsFactory to Typescript (#387)
df08618 
* feat(FeatureManager): add stronger typings and export type from index

* refactor: move sms related files into its own services/sms directory

* tests(Sms): move sms_count specs into nested __tests__ directory

* fix(sms): correct absolute import

* feat(SmsFactory): migrate sms factory to Typescript

* feat: add more info to SmsSendError for Twilio error codes and status

* test(sms): migrate SmsService tests to Typescript

* test(sms): add tests for sendAdminContactOtp fn

* test(SmsFactory): add tests for sms feature disabled state

* test(SmsFactory): add tests for sms feature enabled state

* feat(MailService): sendNodeMail now resolves true on successful send

* feat(VfnService): update sendOTPForField's return type to boolean

* feat(FeatureManager): remove usage of non-null assertion

* chore: trigger travis
@karrui
chore: add lint rule to prevent floating promises (#404)
373761d 
* chore: add lint rule to prevent floating promises

* fix: add await or void calls to floating promises

* feat(FormModel): await pre-validate hook
@tshuli
feat: add trace to logs (#405)
306800f 
* chore: install express-request-id

* chore: update types

* chore: use addRequestId() middleware

* feat: add trace to logs

* chore: add more traces

* chore: include trace in loggingMiddleware
chore: bump version to v4.38.0
e940ef9
@arshadali172
Copy link
Contributor Author

arshadali172 commented Oct 6, 2020 •
edited by karrui
Loading

@karrui

  • At the login page, key in an invalid email address abc@abc.com. Check that the value of cf-ray header is logged under trace in the server logs error message.
  • Access a public form. Check that the value of cf-ray header is logged under trace in the server logs for the get request.

@arshadali172
Copy link
Contributor Author

arshadali172 commented Oct 6, 2020 •
edited by mantariksh
Loading

@mantariksh

  • Check that exclamation is only shown in navbar if sms feature is enabled (On both staging and staging-alt)
  • Check that user emails that are too long on avatar dropdown are shown properly
  • Check that use-template page shows correct submission count and feedback count (On both staging and staging-alt)

@arshadali172
Copy link
Contributor Author

arshadali172 commented Oct 6, 2020 •
edited by tshuli
Loading

@shuli-ogp

  • Errors during form transfer should appear as toastr (Adding a collaborator that already exists, Transferring ownership to a user who has not logged in etc.)

@arshadali172
Copy link
Contributor Author

arshadali172 commented Oct 6, 2020 •
edited
Loading

@arshadali172

  • General run through on IE/Intranet

@arshadali172 arshadali172 merged commit 7359562 into release Oct 6, 2020
@liangyuanruo liangyuanruo deleted the release-v4.38.0 branch January 6, 2021 08:25
@tshuli tshuli mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arshadali172 @mantariksh @karrui @jia1 @awhdesmond @tshuli