build: merge Release 4.44.0 into master #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: merge release 4.43.2 into develop
) Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.12.0 to 6.15.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v6.12.0...v6.15.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 26.0.14 to 26.0.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/spcp-auth-client](https://github.com/opengovsg/spcp-auth-client) from 1.3.5 to 1.3.6. - [Release notes](https://github.com/opengovsg/spcp-auth-client/releases) - [Commits](opengovsg/spcp-auth-client@v1.3.5...v1.3.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ubmission (#525) * feat(FormService): add neverthrown retrieveFullFormById function * feat(PublicFormService): add insertFormFeedback function * feat(FormService): add isFormPublic method * feat(publicFormUtils): add mapRouteError handler * feat(PublicFromCtl): add handler for feedback submission endpoint * feat(FormService): add comments for exported methods * refactor(PublicFormRoutes): use new feedback submission controller * test(PublicFormSvc): add test case for invalid ObjectId * test(PublicFormCtl): add test cases for handleSubmitFeedback * feat(PublicFormCtl): add preconditions to JSDoc for feedback handler * test: delete old submitFeedback tests * refactor(PublicFormSvc): return saved form feedback after insertion * refactor: migrate public-form redirect handler to Typescript (#527) * feat(PublicFormSvc): add createMetatags method * feat(PublicFormCtl): add handleRedirect controller handler function * feat: replace old public-forms controller redirect with new method * chore: add mockingoose and type-fest dev deps * test(PublicFormSvc): add tests for createMetatags * test(PublicFormCtl): add tests for handleRedirect handler * test: remove old redirect tests * fix: revert param back to `Id` * test(PublicFormCtl): extract mockMetatags var to constant
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.770.0 to 2.783.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.770.0...v2.783.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor(AggregateStats): dumb refactor to TS * feat(Examples): add queries file for examples retrieval queries * feat(Examples): add fns for general/search query pipeline creation * feat(Examples): add more examples retrieval queries * feat(DateUtils): add formatToRelativeString fn * feat(ExamplesService): add service method getExamplesForm * refactor(Examples): extract types to their own file * feat(dateUtils): allow nullish date in formatToRelativeString * feat(ExampleQueries): add aggregate steps for searching single forms * feat(examplesUtils): add helper methods for single search pipelines * feat(ExamplesService): add getSingleExampleForm and related methods * feat(ExamplesService): convert exported fns to HOF accepting type * feat(ExamplesFactory): add factory methods to retrieve examples * feat(ExamplesCtl): add controller fn for retrieving examples * fix(examples): update typing for RetrieveSubmissionsExecResult * refactor(routing): add standard type for controller's mapRouteError fn * feat(ExamplesCtl): add handler for retrieving single example form * feat(ExamplesRouter): add router to handle /examples endpoint * feat(ExamplesRouter): add celebrate validation to root endpoint * feat(ExamplesCtl): add handler JSDoc * feat: use ExamplesRouter to handle /examples routes * feat: remove usages of methods related to old examples * refactor(ExamplesService): make map constant UPPER_SNAKE_CASE * test(ExamplesService): add initial tests for empty lists * test(ExamplesService): add tests for getExampleForms using Submission * test(ExamplesSvc): move generation of test data to own function * test(ExamplesSvc): add tests for retrieving from stats collection * test(ExamplesSvc): add tests for single example retrieval * test(ExamplesSvc): add submission counts for better test intuition * test(ExampleSvc): add better comments for generation of test data * test(ExamplesFactory): add tests to check correct service invocation * lint: fix import order * refactor(jest-express): loosen typing of mock request * test(ExamplesCtl): add controller tests * test(Examples): add failure integration tests and empty success cases * test: extract examples test data preparation to own helper * test: update agency helper to be able to name agencies * feat(ExamplesRoute): add guard against invalid object ids * test(ExamplesRoute): add success case scenarios for stats retrieval * test(ExamplesRoute): add success case scenarios for subs retrieval Exact same test code, but using RetrievalType.Submissions for getExampleForms * test(ExamplesRoute): add integration tests for GET/examples/:formId * feat: delete unused admin-console server controller * fix(examplesUtils): JSDoc parameter name * refactor(exampleUtils): extract formatToRelativeString from date utils * feat(ExamplesRoute): remove string casting on Joi validation * refactor(exampleQueries): use status enum * test(Examples): fix tests due to removing string cast from Joi * test(ExampleRoutes): extract helper method to stringify FormInfo doc * refactor(ExamplesSvc): add explicit params to getExamplesQueryBuilder This makes it clearer as to how the `type` param is being used in the main function * feat(exampleUtils): add pipeline comments * test: fix missing comment in test feedback data * feat(Examples): add better comments to searchSubmissionsForForm fn * fix(ExamplesCtl): update error response to be object instead of string This changes ensures error returns shape similar to previous implementation
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.11.6 to 7.12.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.3/packages/babel-core) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.8.3 to 2.8.5. - [Release notes](https://github.com/gcanti/fp-ts/releases) - [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md) - [Commits](gcanti/fp-ts@2.8.3...2.8.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: upgrade chromium * feat: upgrade puppeteer to 5.3.1
mantariksh
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.