-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: payment quantity selector #6669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
changed the title
Feat/payment quantity selector
feat: payment quantity selector
Aug 28, 2023
…t running when stepper buttons were clicked
wanlingt
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Ken! some minor changes
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentCard.tsx
Outdated
Show resolved
Hide resolved
wanlingt
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…ector css for checkbox and radio
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently use a combobox component for the quantity selector, here are the problems with it:
Review the mini-PRD to better understand the UX behaviours
Closes FRM-1252
Solution
<PaymentQuantityModal />
under each<PaymentCard />
<ItemQuantity />
with<ItemQuantityButton />
selector-bottom
size andselector
for<Modal />
size
instead ofvariant
as these themes are specific to breakpoints which is controlled bysize
Breaking Changes
UI Changes
<PaymentCard />
has its background removed as a move towards the new design. Notably the border hover/active is not updated as design is still figuring out the best interaction with the new quantity buttonBug Fixes:
:focus
borderBefore & After Screenshots
Before
PaymentPreview
After
Mobile View
Desktop View
PaymentPreview
Tests
Payment Modal
Modal x PaymentCard
data mutation, on adminname: min qty 1 max qty 99, description: bar, amt: 1, multi_qty: min_qty: 1, max_qty: 99
Qty: 1
99
X
button closes the modalQty: 1
99
Cancel
button closes the modalQty: 1
99
Qty: 99
PaymentPreview
updates toS$99.00
Modal x PaymentCard
data mutation, on responder sidename: min qty 1 max qty 99, description: bar, amt: 1, multi_qty: min_qty: 1, max_qty: 99
Qty: 1
99
Qty: 99
PaymentPreview
updates toS$99.00
S$99.00
Item without multi_qty
name: no multi_qty, description: bar, multi_qty: toggled off
Item with min and max as 1
name: min qty 1 max qty 1, description: bar, multi_qty: toggled on, min_qty: 1, max_qty: 1
Qty: 1
1
1
(the min_qty)Item with non min of 1
name: min qty 2 max qty 99, description: bar, multi_qty: min_qty: 2, max_qty: 99
Qty: 2
2
2
(the min_qty)Item quantity taking large width
name: min qty 1 max qty 200000, description: bar, amt: 1, multi_qty: min_qty: 1, max_qty: 200000
200000
Qty: 200000
with the button width increased to accommodate the valuesMobile View
On a mobile screen (
<768px
)