Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add myinfo errors to error map for storage-mode submissions #6931

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: add myinfo errors to error map for storage-mode submissions #6931

merged 1 commit into from
Nov 28, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Nov 28, 2023 •
edited
Loading

Problem

MyInfo errors were not captured in the error mapping for storage-mode submissions

Solution

Add the MyInfo errors, referencing email-submission.util.ts

@wanlingt wanlingt enabled auto-merge (squash) November 28, 2023 03:52
KenLSM
KenLSM approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wanlingt wanlingt merged commit 0e44726 into develop Nov 28, 2023
29 checks passed
@wanlingt wanlingt deleted the fix/myinfo-errors branch November 28, 2023 04:38
@KenLSM KenLSM mentioned this pull request Nov 28, 2023
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

@sebastianwzq sebastianwzq Awaiting requested review from sebastianwzq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wanlingt @KenLSM