Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.92.0 #6932

Merged
merged 16 commits into from
Nov 28, 2023
Merged

build: release v6.92.0 #6932

merged 16 commits into from
Nov 28, 2023

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Nov 28, 2023

New

  • fix: add myinfo errors to error map for storage-mode submissions #6931
  • feat(FE): set secret key input to password type #6930
  • feat: add prefills for variable payments #6899
  • chore: update package repo for font-wqy-zenhei package #6920
  • feat(payments): add paynow payment method #6900
  • build: merge Release 6.91.1 into develop #6925

Dependencies

  • fix(deps): bump libphonenumber-js from 1.10.48 to 1.10.51 in /shared #6926
  • fix(deps): bump type-fest from 4.8.1 to 4.8.2 in /shared #6923

Dev-Dependencies

  • chore(deps-dev): bump @types/lodash from 4.14.201 to 4.14.202 in /shared #6921

Tests

feat(FE): set secret key input to password type #6930

Regression

  • Ensure secret key on storage mode form is shown as a password field (*)

feat: add prefills for variable payments #6899

Regression

Ensure that prefill works on non-payment forms
  • On a regular form
  • Toggle on prefill for a Short Text field
  • Append prefilled id + data on the URL
  • Ensure that the Short Text field is prefilled
Prefills happy flow
  • Add a payment variable to a form
  • Append ?payment_variable_input_amount_field_id=<amount_in_cents> to the end of the url
  • Observe that the variable input field is prefilled
Prefills happy flow with other prefillable fields
  • Add a payment variable to a form
  • Toggle on prefill for a Short Text field
  • Append prefilled id + data on the URL
  • Append &payment_variable_input_amount_field_id=<amount_in_cents> to the end of the url (note that we're trying to have two prefills on the URL. 1 for Short Text, another for Variable Payments`
  • Observe that the variable input field is prefilled
Prefills invalid data flow
  • Create a new payment variable form
  • Append ?payment_variable_input_amount_field_id=THIS_IS_NOT_A_NUMBER to the end of the url
  • Observe that the variable input field is not prefilled

feat(payments): add paynow payment method #6900

Regression

  • Find an existing payment form
  • Make a payment
  • Ensure that both payment methods "Cards", and "Paynow" are available to be selected

New features

Newly created forms should have both "Cards" and "Paynow" payment methods
  • Create a new payment form
  • Make a payment
  • Ensure that both payment methods "Cards", and "Paynow" are available to be selected
Forms with enabled toggle should only allow "Paynow" payment method
  • Create a new payment form
  • Upsert form.payments_channel.payment_methods: ["Paynow"] to the form on DB
  "payments_channel": {
    "channel": "Stripe",
    "target_account_id": "acct_****",
    "publishable_key": "pk_test_****",
    "payment_methods": [
      "Paynow"
    ]
  },
  • Make a payment
  • Ensure that only payment method "Paynow" is available to be selected

KenLSM and others added 16 commits November 20, 2023 16:18
build: merge release 6.90.0 to develop
* chore: import react google charts

* feat: create skeleton insights page

* fix: regex for route matching for insight page

* fix: layout of insights page

* feat: dummy endpoint for all encrypted data

* feat: queries to get all encrypted submission

* fix: encrypted model find params

* feat: get and decrypted all submission data

* feat: get formfields

* feat: generate charts

* fix: typing of spacing

* feat: create mapping for field to charts

* feat: some upgrades to format charts

* feat:wordcloud

* fix: remove excess divider

* fix: prefill rating values in bar chart

* feat: add question number to chart title

* feat: skeleton for changing chart to table

* chore: add gstatic charts to csp policy

* fix: rating average counting

* feat: table toggle mode

* feat: use icon button instead of toggle

* feat: dummy date picker

* fix: better date range picker styling

* feat: date range filtering

* fix: do not show rating if no values

* fix: filtering by date and styling

* fix: increase size of charts

* fix: do not display wordcloud if no words

* fix: alignment of wordcloud title

* fix: typing for submission insights dto

* refactor: make code more readable

* fix: typing of render array

* fix: do not randomize color for rating

* feat: fix bar graph colours changing on refocus

* feat: fix random word cloud movements on re-render

* feat: address MR comments

* feat: corrected types and fixed lint comments

* feat: update average rating to account for division by 0

* feat: refactored filter function to remove redundant date parsing

* feat: set max words for word cloud

* fix: fe lint issue

* refactor: cleanup constants

* feat: add growthbook toggle

* fix: flickering pie chart tooltip

* fix: ordering of frontend/package.json

* chore: add utils

* feat: add empty insights field

* fix: typeerror on admin submission

* refactor: rename insights to charts

* feat: add beta badge

* refactor: secretkeyverification to common component for results and charts tab

* fix: table charts ui

* fix: charts secretkeyvewrification component

* fix: remove stray space between charts and badge on tab title

* fix: remove testing flag

* chore: update copy for no charts generted

* fix: endday not calculated correctly

* feat(be): add limit and reverse chrono sort for submissions query

* feat(fe): add forced redirect for email charts

* chore: update charts supported field for better visual alignment with secret key section

* feat: add marketing prompts for charts

* chore: add copy for 1000 chart limit

* chore: shorten copy

* refactor: create daterangepicker helpers

* refactor: use helpers from daterangepicker

* feat: add no charts prompt

* chore: update language to omit implication of uncertainty

* fix: number typo

* feat: correctly retrieve based on date range

* fix: remove incorrect generic

* fix: remove unnecessary comment

---------

Co-authored-by: Timothee Groleau <timothee.groleau@gmail.com>
Co-authored-by: sebastianwzq <sebastian@open.gov.sg>
Co-authored-by: Ken <ken@open.gov.sg>
Co-authored-by: tshuli <shuli@open.gov.sg>
…ps (#6917)

fix: refine regex to handle newlines after indentation groups
…red (#6921)

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.201 to 4.14.202.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.8.1 to 4.8.2.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.8.1...v4.8.2)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6926)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.48 to 1.10.51.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.48...v1.10.51)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge Release 6.91.1 into develop
* feat: add paynow payment method

* fix: remove payment method type of unset

* fix: test fixture

* chore: remove unused enum
* feat: add prefills for variable payments

* chore: ensure payment value is more than zero
feat: set secret key input to password type
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that secret key input on activation modal is password type

@wanlingt wanlingt merged commit 43faab5 into release-al2 Nov 28, 2023
41 of 43 checks passed
@wanlingt wanlingt deleted the release_v6.92.0 branch November 28, 2023 07:30
@wanlingt wanlingt mentioned this pull request Dec 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants