feat: update payments thank you page header #7020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathleenkhy
force-pushed
the
feat/payments-thank-you-page-header
branch
from
0ab9d86
to
ca326d5
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-page-header
branch
from
ca326d5
to
38ec85d
Compare
KenLSM
reviewed
Jan 31, 2024
KenLSM
reviewed
Jan 31, 2024
...end/src/features/public-form/components/FormPaymentPage/components/PaymentFormBannerLogo.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
...end/src/features/public-form/components/FormPaymentPage/components/PaymentFormBannerLogo.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentHeader.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/public-form/components/FormPaymentPage/stripe/StripePaymentElement.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentHeader.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/public-form/components/FormPaymentPage/components/PaymentHeader.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/public-form/components/FormPaymentPage/stripe/StripePaymentElement.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Feb 2, 2024
...end/src/features/public-form/components/FormPaymentPage/components/PaymentFormBannerLogo.tsx
Outdated
Show resolved
Hide resolved
KenLSM
requested changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, payment forms are showing a header that is meant for forms which have not completed submission yet. This banner should be hidden where the payment forms' thank you page (after completing payment) should be standardised to only show the header reflecting the agency logo, which is the behaviour for non-payment forms.
Closes FRM-1537
Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
