feat(mrf): dynamic routing #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
temporarily deployed
to
staging-alt2
GitHub Actions
Inactive
justynoh
force-pushed
the
feat/dynamic-routing
branch
from
74c994c
to
d8298e1
Compare
justynoh
force-pushed
the
feat/dynamic-routing
branch
from
d8298e1
to
b428061
Compare
KenLSM
force-pushed
the
feat/dynamic-routing
branch
from
8e07db6
to
969cc00
Compare
KenLSM
reviewed
Feb 18, 2024
KenLSM
reviewed
Feb 18, 2024
KenLSM
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On top of the workflow builder, we want to build dynamic routing as a feature.
Closes FRM-1621
Solution
This PR adds instrumentation for dynamic routing in the frontend and backend. Importantly, this builds on top of #7072.
On the frontend, we add a radio toggle for admins to select whether they want to do static or dynamic routing. If static, the original text box is shown. If dynamic, we display a dropdown of all the email fields in the form for their selection.
On the backend, Joi validation for the settings PATCH endpoint is updated. Additionally, the schema and model for multirespondent form workflows is updated with a discriminator on the
workflow_typeto accommodate the two types of data now needed to be stored mutually exclusively -emailsfor static, andfieldfor dynamic. Finally, on the MRF submission endpoint, the email retrieval computation is updated to include the case where the routing is dynamic.Breaking Changes
Screenshots
Screen.Recording.2024-02-13.at.5.09.54.PM.mov