Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.110.0 #7104

Merged
merged 16 commits into from
Feb 21, 2024
Merged

build: release v6.110.0 #7104

merged 16 commits into from
Feb 21, 2024

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Feb 21, 2024

New

  • feat(mrf): retain workflow through a submission lifetime #7087
  • feat(config): allow R2 bucket URLs #7097
  • feat(mrf): frontend field locking #7091
  • feat: payments thank you page preview and edit mode #6969
  • fix(mrf): use undefined as default for response display #7095
  • feat(mrf): dynamic routing #7078
  • build: merge release v6.109.0 into develop #7085
  • chore(dev): update README with clearer virus-scanner install instructions #7083
  • build: release v6.109.0 #7081

Dependencies

  • chore(deps): update ip package #7098
  • build(deps): bump ip from 2.0.0 to 2.0.1 in /serverless/virus-scanner #7101
  • build(deps): bump ip from 2.0.0 to 2.0.1 in /scripts/20230317_whitespace_issue #7100
  • fix(deps): bump ip from 1.1.8 to 1.1.9 #7099
  • chore(deps): fix synk vulnerabilities #7089

Dev-Dependencies

  • build(deps-dev): bump ip from 1.1.8 to 1.1.9 in /frontend #7102
  • chore(deps-dev): bump semver from 5.7.1 to 5.7.2 #7090

Tests

feat(mrf): retain workflow through a submission lifetime #7087
@kathleenkhy

  • Create an MRF form without a workflow. The usual response link passing should still work, with all fields enabled for all respondents.
  • Create an MRF form.
    • Create a workflow where step 2 is a static value a@gov.sg and step 3 is another static value b.gov.sg.
    • Submit the form once as Respondent 1. a@gov.sg should receive an email reminder to submit the form.
    • Now, change step 3 to be a different static value c@gov.sg.
    • Click the button in the email that a@gov.sg received to fill the form. Submit the form.
    • Check that b@gov.sg got the next respondent email, and not c@gov.sg.

feat: payments thank you page preview and edit mode #6969
@KenLSM
Payments Form

Ensure that design is updated in Edit mode
  • Add a payment variable to a form
  • Check that the Thank You page shows the latest design
  • The Button text and Button redirect link should be disabled
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
Ensure that design is updated in Preview mode
  • Click on the Preview (eye) button of the form in admin mode
  • Check that the Thank You page shows the latest design
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
Thank you page happy flow with actual form
  • Click on the share button to launch theform
  • Complete the payment flow and submit the form
  • Check that the Thank You page shows the latest design
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the invoice PDF should be downloaded

Non-Payments Form

In Edit Mode
  • Remove the payment variable/ component of the form
  • Check that the Thank You page should reflect the default non-payment Thank you page
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
In Preview Mode
  • Click on the Preview (eye) button of the form in admin mode
  • Check that the Thank You page shows the default, non-payment design
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
In Actual Form
  • Click on the share button to launch the form
  • Check that the Thank You page shows the default, non-payment design
  • Upon clicking the Submit another response button, the form should be refreshed to show a new form

Deploy notes

  • 20240214_mrf-workflow-field-locking : This DB migration script adds the edit key for all workflow steps, which allows users to choose the fields each respondent is allowed to edit. To preserve existing behavior, all respondents must be allowed to edit all fields. Therefore, a copy of the form fields (excl non-input fields section, statement and image) are copied into every edit key.
  • mrf-retain-workflow-in-submissions : This DB migration script creates a new workflow key in all existing mrf submissions, populated with the form's existing workflow. From this point on, workflows should be captured when the submission is initially created (i.e. the workflow is started)

justynoh and others added 16 commits February 14, 2024 13:19
…ions (#7083)

chore: update README with clearer virus-scanner install instructions
build: merge release v6.109.0 into develop
* chore: remove unused deps

* chore: update ansi-regex with bumps to bcrypt, stoplight-prism package

* chore: upgrade @babel/core, jsonwebtoken, @types/bcrypt

* chore: move stoplight/prism to devdeps
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: dynamic routing

* fix: use getValues instead of watch for default values

* chore: revert changes to logic that were accidentally made

* chore: delete refactored files

* fix: add loading states for inputs in edit step block

* chore: suppress unused var ts-warning in exhaustive checks

* chore: remove unused comments

* chore: use single element type

* fix: tighten validation for static emails

---------

Co-authored-by: Ken <ken@open.gov.sg>
* feat: allowing payments thank you page to be editable

* feat: save changes on preview and update thank you image

* feat: add payment thank you design in preview edit mode

* feat: update cost breakdown in thank you page section

* feat: add logic for multi products in preview

* feat: add payments thank you page in preview form mode

* chore: fix failing backend:ci test

* chore: remove redundant code

* fix: refactoring code for easier readability

* fix: correct components spacing in thank you page

* fix: add changes after design review for submission

* chore: fix padding for thank you page in preview after design review

* chore: fix changes after code review

* chore: fix chromatic tests and alignment

* chore: fix alignment padding issues

* fix: allow buttons in edit and preview mode to reload when clicked

---------

Co-authored-by: Kathleen Koh <kathleenkoh@Kathleens-MacBook-Pro.local>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ace_issue (#7100)

build(deps): bump ip in /scripts/20230317_whitespace_issue

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#7101)

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add workflow to public form keys for MRFs

* feat: add option to select questions to fill in workflow builder

* feat: frontend locking based on selected workflow questions

* test: fix tests

* chore: move const closer to usage

* chore: rewrite code to better clarify logic

* chore: rewrite function call to augmentWithWorkflowDisabling to be clearer
chore: update ip package
- Allow config to accept URLs to R2 buckets, in addition to S3 buckets
- Force path-style S3 URLs for R2 buckets, not just for dev mode
* feat: retain workflow through a submission lifetime

* test: fix submission model tests with workflow object

* fix: add db migration script

* chore: update package-lock for virus scanner
@KenLSM
Copy link
Contributor

KenLSM commented Feb 21, 2024

Ensure that design is updated in Preview mode
The text should still be within the Summary table if the product name is very long

@kathleenkhy Non-blocking issue

Text bleeds through on preview mode (doesn't bleed on edit nor actual form)
Screenshot 2024-02-21 at 2 23 12 PM

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 non-blocking issue. LGTM

@justynoh justynoh merged commit df70ae1 into release-al2 Feb 21, 2024
77 checks passed
@justynoh justynoh deleted the release_v6.110.0 branch February 21, 2024 06:29
@KenLSM KenLSM mentioned this pull request Mar 4, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants