-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release v6.110.0 #7104
Merged
Merged
build: release v6.110.0 #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (#7083) chore: update README with clearer virus-scanner install instructions
build: merge release v6.109.0 into develop
* chore: remove unused deps * chore: update ansi-regex with bumps to bcrypt, stoplight-prism package * chore: upgrade @babel/core, jsonwebtoken, @types/bcrypt * chore: move stoplight/prism to devdeps
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: dynamic routing * fix: use getValues instead of watch for default values * chore: revert changes to logic that were accidentally made * chore: delete refactored files * fix: add loading states for inputs in edit step block * chore: suppress unused var ts-warning in exhaustive checks * chore: remove unused comments * chore: use single element type * fix: tighten validation for static emails --------- Co-authored-by: Ken <ken@open.gov.sg>
* feat: allowing payments thank you page to be editable * feat: save changes on preview and update thank you image * feat: add payment thank you design in preview edit mode * feat: update cost breakdown in thank you page section * feat: add logic for multi products in preview * feat: add payments thank you page in preview form mode * chore: fix failing backend:ci test * chore: remove redundant code * fix: refactoring code for easier readability * fix: correct components spacing in thank you page * fix: add changes after design review for submission * chore: fix padding for thank you page in preview after design review * chore: fix changes after code review * chore: fix chromatic tests and alignment * chore: fix alignment padding issues * fix: allow buttons in edit and preview mode to reload when clicked --------- Co-authored-by: Kathleen Koh <kathleenkoh@Kathleens-MacBook-Pro.local>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ace_issue (#7100) build(deps): bump ip in /scripts/20230317_whitespace_issue Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#7101) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add workflow to public form keys for MRFs * feat: add option to select questions to fill in workflow builder * feat: frontend locking based on selected workflow questions * test: fix tests * chore: move const closer to usage * chore: rewrite code to better clarify logic * chore: rewrite function call to augmentWithWorkflowDisabling to be clearer
chore: update ip package
- Allow config to accept URLs to R2 buckets, in addition to S3 buckets - Force path-style S3 URLs for R2 buckets, not just for dev mode
* feat: retain workflow through a submission lifetime * test: fix submission model tests with workflow object * fix: add db migration script * chore: update package-lock for virus scanner
@kathleenkhy Non-blocking issue Text bleeds through on preview mode (doesn't bleed on edit nor actual form) |
KenLSM
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 non-blocking issue. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
#7087
#7097
#7091
#6969
#7095
#7078
#7085
#7083
#7081
Dependencies
#7098
#7101
#7100
#7099
#7089
Dev-Dependencies
#7102
#7090
Tests
feat(mrf): retain workflow through a submission lifetime #7087
@kathleenkhy
a@gov.sg
and step 3 is another static valueb.gov.sg
.a@gov.sg
should receive an email reminder to submit the form.c@gov.sg
.a@gov.sg
received to fill the form. Submit the form.b@gov.sg
got the next respondent email, and notc@gov.sg
.feat: payments thank you page preview and edit mode #6969
@KenLSM
Payments Form
Ensure that design is updated in Edit mode
Button text
andButton redirect
link should be disabledSave proof of payment
button, the page should be refreshed/ reloadedEnsure that design is updated in Preview mode
Save proof of payment
button, the page should be refreshed/ reloadedThank you page happy flow with actual form
Save proof of payment
button, the invoice PDF should be downloadedNon-Payments Form
In Edit Mode
Save proof of payment
button, the page should be refreshed/ reloadedIn Preview Mode
Save proof of payment
button, the page should be refreshed/ reloadedIn Actual Form
share
button to launch the formSubmit another response
button, the form should be refreshed to show a new formDeploy notes
20240214_mrf-workflow-field-locking
: This DB migration script adds theedit
key for all workflow steps, which allows users to choose the fields each respondent is allowed to edit. To preserve existing behavior, all respondents must be allowed to edit all fields. Therefore, a copy of the form fields (excl non-input fieldssection
,statement
andimage
) are copied into everyedit
key.mrf-retain-workflow-in-submissions
: This DB migration script creates a new workflow key in all existing mrf submissions, populated with the form's existing workflow. From this point on, workflows should be captured when the submission is initially created (i.e. the workflow is started)