fix(mrf): workflow email UI cleanup #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KenLSM
reviewed
Apr 3, 2024
KenLSM
added a commit
that referenced
this pull request
Apr 4, 2024
* chore(deps-dev): bump @types/express from 4.17.17 to 4.17.21 (#7233) Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.17 to 4.17.21. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) --- updated-dependencies: - dependency-name: "@types/express" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(deps): bump nan from 2.17.0 to 2.19.0 (#7212) Bumps [nan](https://github.com/nodejs/nan) from 2.17.0 to 2.19.0. - [Changelog](https://github.com/nodejs/nan/blob/main/CHANGELOG.md) - [Commits](nodejs/nan@v2.17.0...v2.19.0) --- updated-dependencies: - dependency-name: nan dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/json-stringify-safe from 5.0.0 to 5.0.3 (#7235) Bumps [@types/json-stringify-safe](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/json-stringify-safe) from 5.0.0 to 5.0.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/json-stringify-safe) --- updated-dependencies: - dependency-name: "@types/json-stringify-safe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(mrf): handling for incorrect submission secret key in url query params (#7219) * fix: add secret key input mask (#7227) * fix: add secret key input mask * fix: add testid to allow storybook to capture inputfield with password type * fix(mrf): workflow email UI cleanup (#7215) * fix: mrf workflow email UI cleanup * chore: update button formatting * fix: more fixes * chore: change port for react-email-preview to 4242 * chore: add comment on email defaults * fix: potentially unsafe external url * chore(mrf): remove flags (#7230) chore: remove mrf flag checks * chore(mrf): add announcement content (#7229) * chore: add mrf announcement content * chore: update mrf guide links * chore: update date to 04-04 * chore: remove exclamation mark after url link * fix: correct date validation for disabled fields (#7240) * fix: correct date validation for disabled fields * fix: removing console logs * chore: bump version to v6.115.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justyn Oh <justynoh@gmail.com> Co-authored-by: Kathleen Koh <89055608+kathleenkhy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to clean up our workflow email.
Closes FRM-1701 , FRM-1608 , FRM-1695 , FRM-1697
Solution
Use a new package
react-emailwhich transforms react-style code into email-compatible code. Also adds a preview environment for emails inreact-email-preview->npm run dev->localhost:4242.Breaking Changes
Screenshots
gmail
gsib
