Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.115.0 #7241

Merged
merged 11 commits into from
Apr 4, 2024
Merged

build: release v6.115.0 #7241

merged 11 commits into from
Apr 4, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 3, 2024 •
edited
Loading

New

  • fix: correct date validation for disabled fields #7240
  • build: merge release v6.114.1 back to develop #7228
  • chore(mrf): add announcement content #7229
  • chore(mrf): remove flags #7230
  • fix(mrf): workflow email UI cleanup #7215
  • fix: add secret key input mask #7227
  • fix: correcting submission button bug for MRF #7232
  • fix(mrf): handling for incorrect submission secret key in url query params #7219
  • chore: bump version to v6.115.0 8f02ef7

Dependencies

  • fix(deps): bump nan from 2.17.0 to 2.19.0 #7212

Dev-Dependencies

  • chore(deps-dev): bump @types/json-stringify-safe from 5.0.0 to 5.0.3 #7235
  • chore(deps-dev): bump @types/express from 4.17.17 to 4.17.21 #7233

Tests

fix: correct date validation for disabled fields #7240

@KenLSM

  • Create an MRF form and add a date field with a validation (eg. prevent past dates)
  • Go to Workflow to create multiple workflows
  • Add the date fields for Workflow 1
  • Add more fields for Workflow 2 onwards
  • Share the form and select a future date - submit the form
  • Open the form for Respondent 2
  • Copy the Submission ID, proceed to the DB and search for the submission ID - change the selected date validation to "selectedDateValidation" : "Disallow future dates"
  • Refresh the page for the MRF form for Respondent 2
  • Fill up the remaining fields in the form and submit as Respondent 2 - you should be able to submit the form

chore(mrf): remove flags #7230

@kathleenkhy

Regression
  • Remove betaflag in the db on current user
  • Create new Form
  • Ensure that MRF selection is available to be selected
  • Ensure fields can be added onto newly created MRF form
  • Ensure that MRF workflow can be added onto newly created MRF form
  • Open form
  • Make a submission as a respondent
  • Ensure that submission is successful
  • Go to Admin Results Page
  • Ensure that the latest MRF response is listed
  • Ensure that the latest MRF individual response can be viewed

fix: correcting submission button bug for MRF #7232

@justynoh

  • Create a non-payment form
  • Proceed to the Thank You page tab

MRF Form test

  • Create an MRF form
  • Create 2 workflows
  • Submit the 1st workflow - the Submit another response button should be present
  • Submit the 2nd workflow - the Submit another response button should not be present

dependabot bot and others added 11 commits April 2, 2024 17:44
@dependabot
chore(deps-dev): bump @types/express from 4.17.17 to 4.17.21 (#7233)
2bdd366 
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.17 to 4.17.21.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express)

---
updated-dependencies:
- dependency-name: "@types/express"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump nan from 2.17.0 to 2.19.0 (#7212)
d76e133 
Bumps [nan](https://github.com/nodejs/nan) from 2.17.0 to 2.19.0.
- [Changelog](https://github.com/nodejs/nan/blob/main/CHANGELOG.md)
- [Commits](nodejs/nan@v2.17.0...v2.19.0)

---
updated-dependencies:
- dependency-name: nan
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/json-stringify-safe from 5.0.0 to 5.0.3 (#…
e9fbe89 
…7235)

Bumps [@types/json-stringify-safe](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/json-stringify-safe) from 5.0.0 to 5.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/json-stringify-safe)

---
updated-dependencies:
- dependency-name: "@types/json-stringify-safe"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@justynoh
fix(mrf): handling for incorrect submission secret key in url query p…
02f7429 
…arams (#7219)
@KenLSM
fix: add secret key input mask (#7227)
6cc48a3 
* fix: add secret key input mask

* fix: add testid to allow storybook to capture inputfield with password type
@justynoh
fix(mrf): workflow email UI cleanup (#7215)
44a0607 
* fix: mrf workflow email UI cleanup

* chore: update button formatting

* fix: more fixes

* chore: change port for react-email-preview to 4242

* chore: add comment on email defaults

* fix: potentially unsafe external url
@KenLSM
chore(mrf): remove flags (#7230)
030c3a5 
chore: remove mrf flag checks
@KenLSM
chore(mrf): add announcement content (#7229)
d3ab1e2 
* chore: add mrf announcement content

* chore: update mrf guide links

* chore: update date to 04-04

* chore: remove exclamation mark after url link
@KenLSM
Merge pull request #7228 from opengovsg/release-al2
6fc3153 
build: merge release v6.114.1 back to develop
@kathleenkhy
fix: correct date validation for disabled fields (#7240)
d30f62e 
* fix: correct date validation for disabled fields

* fix: removing console logs
@KenLSM
chore: bump version to v6.115.0
8f02ef7
@KenLSM KenLSM enabled auto-merge April 4, 2024 01:58
justynoh
justynoh approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KenLSM KenLSM merged commit 16484da into release-al2 Apr 4, 2024
70 of 73 checks passed
@KenLSM KenLSM deleted the release_v6.115.0 branch April 4, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh approved these changes

@kathleenkhy kathleenkhy Awaiting requested review from kathleenkhy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KenLSM @justynoh @kathleenkhy