Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/is-form-public: migrate isFormPublic middleware to TypeScript #791

Merged
merged 6 commits into from
Dec 11, 2020
Merged

refactor/is-form-public: migrate isFormPublic middleware to TypeScript #791

merged 6 commits into from
Dec 11, 2020

Commits on Dec 10, 2020

  1. refactor: move to public-form module as a middleware file

    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    a72e039 View commit details
    Browse the repository at this point in the history

  2. refactor: convert file to TypeScript

    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8e0ef9e View commit details
    Browse the repository at this point in the history

  3. refactor: re-implement to rely on form.service.ts, and renaming to is… 

    …FormPublicCheck to avoid mirroring name of the same function in the service
    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    11d3a9c View commit details
    Browse the repository at this point in the history

  4. test: add tests for the middleware

    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    ac6046f View commit details
    Browse the repository at this point in the history

  5. fix: delete jasmine tests

    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f2e0b9d View commit details
    Browse the repository at this point in the history

  6. fix: remove superfluous use strict

    Yuanruo Liang committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    d090503 View commit details
    Browse the repository at this point in the history