refactor/is-form-public: migrate isFormPublic middleware to TypeScript #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this one i migrate liow (in auth.service.ts), just havent migrate the middleware 😢 nvm can have both for now haha |
Yeah, I'm porting it over first since it's still in production use. We can refactor to collapse the controllers later if we like. Can help approve? |
added 6 commits
December 10, 2020 16:33
…FormPublicCheck to avoid mirroring name of the same function in the service
liangyuanruo
force-pushed
the
refactor/is-form-public
branch
from
915fed4
to
d090503
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Addresses #144
Solution
The existing
isFormPublicmiddleware function was mirroring another function of the same name inform.service.ts, so I ported the middleware function to be built on the service instead.