build: merge release 4.48.2 into master #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: merge release 4.47.0 into develop
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.5.1 to 10.5.2. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.5.1...v10.5.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.6.1 to 13.8.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](stylelint/stylelint@13.6.1...13.8.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps-dev): bump prettier from 2.1.2 to 2.2.0 Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@2.1.2...2.2.0) Signed-off-by: dependabot[bot] <support@github.com> * fix: lint Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
…711) * feat(EncryptSubSvc): add getSubmissionMetadata service fn (and tests) * feat(EncryptSubSvc): add getSubmissionMetadataList service fn (+tests) * feat(EncryptSubCtl): add handleGetMetadata fn * ref(AdminFormRoutes): use new handleGetMetadata handler fn * feat(AdminFormRoutes): allow optional page when submissionId exists * test(EncryptSubCtl): add tests for handleGetMetadata
* refactor: migrate radioButtonValidator to ts * refactor: update references * chore: update isVisible for tests
* refactor: migrate ratingValidator to ts * refactor: update references
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 26.4.1 to 26.4.4. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v26.4.1...v26.4.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: migrate mobileValidator to ts * refactor: update references * chore: correct param name * refactor: improve clarity of prefixValidator
Bumps [winston-cloudwatch](https://github.com/lazywithclass/winston-cloudwatch) from 2.3.2 to 2.4.0. - [Release notes](https://github.com/lazywithclass/winston-cloudwatch/releases) - [Changelog](https://github.com/lazywithclass/winston-cloudwatch/blob/master/CHANGELOG.md) - [Commits](https://github.com/lazywithclass/winston-cloudwatch/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [angular-messages](https://github.com/angular/angular.js) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.1...v1.8.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express-rate-limit](https://github.com/nfriedly/express-rate-limit) from 5.1.3 to 5.2.3. - [Release notes](https://github.com/nfriedly/express-rate-limit/releases) - [Commits](express-rate-limit/express-rate-limit@v5.1.3...v5.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ref: pass length validator function to chain * ref: use flow instead of pipe * ref: cut indirection in homeno * ref: cut indirection in mobileno * ref: cut indirection in nric * ref: cut indirection in radiobutton * ref: cut indirection in rating * ref: improve variable name for textfield
* feat(FeedbackModel): add static method getFeedbackCursorByFormId * feat(FeedbackSvc): add getFormFeedbackStream fn * feat(AdminFormCtl): add handleStreamFormFeedback fn * feat(utils): add exhaustive switch case typeguard * ref(AdminFormsRoutes): use new handleStreamFormFeedback handler * test(FormFeedbackModel): add tests for model schema and statics * feat(AuthService): add getFormAfterPermissionChecks helper function * test(AuthService): add test cases for getFormAfterPermissionChecks * ref(AdminFormCtl): use getFormAfterPermissionChecks fn in controllers * test(AdminFormCtl): add tests for handleStreamFormFeedback Note that I have no clue how to test express streams, and my Google-fu failed me this time. Thus, the success case test is just testing that the services return correctly and not whether the stream passes :( * feat: remove unused code and add jsdoc for handler * test(AuthSvc): replace assertSpy with inlined mock
Bumps [eslint](https://github.com/eslint/eslint) from 7.13.0 to 7.14.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.13.0...v7.14.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.1 to 7.12.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-preset-env) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [opossum](https://github.com/nodeshift/opossum) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/nodeshift/opossum/releases) - [Changelog](https://github.com/nodeshift/opossum/blob/master/CHANGELOG.md) - [Commits](nodeshift/opossum@v5.0.1...v5.0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: update travis to have multiple build stages * chore: use correct paths * chore: remove create * fix: missing script tag * chore: correct order of stages * chore: experiment with only building node_modules once * chore: add default language without install step * chore: use node_js 12 in all Travis stages * chore: run lint-ci concurrently * chore: copy all in coverage workspace * chore: run coveralls after_success * chore: use node testEnvironment when running Jest tests Allows for speed up of Jest tests See: https://itnext.io/how-to-make-your-sluggish-jest-v23-tests-go-faster-1d4f3388bcdd * chore: increase number of parallel workers in Jest to 4 * chore: remove unnecessary coverage reporters in Jest
Bumps [ts-mock-imports](https://github.com/EmandM/ts-mock-imports) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/EmandM/ts-mock-imports/releases) - [Commits](EmandM/ts-mock-imports@v1.3.0...v1.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongoose) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongoose) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [celebrate](https://github.com/arb/celebrate) from 13.0.3 to 13.0.4. - [Release notes](https://github.com/arb/celebrate/releases) - [Commits](arb/celebrate@v13.0.3...v13.0.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.10.15 to 5.10.18. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.10.15...5.10.18) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…736) * fix: add check for responses on hidden fields * fix: correct isVisible values for tests * chore: update status code on ValidateFieldError * fix: remove invalid visibility tests from server controller spec because hidden field answers should not even be in the response * chore: add tests for hidden fields in field validator specs * refactor: type FieldResponse as union of Response interfaces * refactor: use else if * chore: tighten type guards for checkbox and table responses * fix: check for table response on hidden field * refactor: TableRow subtype * fix: concatenate flattened array for table response before evaluating length * refactor: beforeAll and afterAll for jasmine clock * chore: add check that all arrays have same length * refactor: type ITableRow is string array * refactor: check if array contains any value by traversing each element instead of using string concatenation * chore: check that answerArray[0] exists and is a tableRow
* chore: change copy * style: standardise top and bottom padding * chore: remove period
karrui
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.