feat: updated Docker and CI for Datadog integration #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…govsg/GoGovSG into feature/datadog-integration
yong-jie
requested changes
Jul 25, 2022
| <path d="M168.84 62.08C170.127 62.08 171.17 61.0368 171.17 59.75C171.17 58.4632 170.127 57.42 168.84 57.42C167.553 57.42 166.51 58.4632 166.51 59.75C166.51 61.0368 167.553 62.08 168.84 62.08Z" stroke="#472F40" stroke-linecap="round" stroke-linejoin="round"/> | ||
| <path d="M190.38 63.91C192.495 63.91 194.21 62.1953 194.21 60.08C194.21 57.9648 192.495 56.25 190.38 56.25C188.265 56.25 186.55 57.9648 186.55 60.08C186.55 62.1953 188.265 63.91 190.38 63.91Z" stroke="#472F40" stroke-linecap="round" stroke-linejoin="round"/> | ||
| <path d="M150.56 65.7C151.326 66.9066 152.024 68.1552 152.65 69.44C153.356 70.8854 153.967 72.3752 154.48 73.9C153.442 74.8645 152.335 75.7535 151.17 76.56C149.297 77.8552 147.285 78.9354 145.17 79.78" stroke="#402A38" stroke-linecap="round" stroke-linejoin="round"/> | ||
| <svg width="490" height="153" viewBox="0 0 490 153" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
was this file edit intentional? seems out of scope of this datadog PR
yong-jie
approved these changes
Jul 25, 2022
gweiying
reviewed
Jul 25, 2022
| env: | ||
| REPO: ${{env.ECR_URL}}/${{env.ECR_REPO}} | ||
| TAG: ${{ needs.build-edu.outputs.tag }} | ||
| DD_API_KEY: ${{ secrets.DD_API_KEY }} | ||
| DD_ENV: ${{ env.NODE_ENV }} |
There was a problem hiding this comment.
Belated review but there's a small error here, this resolves to null as there's no NODE_ENV variable defined in this VM.
There was a problem hiding this comment.
Should be SERVERLESS_STAGE
There was a problem hiding this comment.
Sure, I will fix in another MR 🌮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Datadog integration
Solution
Updated