Replace tweetnacl-util Base64 functions with StableLib #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
suggested changes
May 28, 2020
There was a problem hiding this comment.
code lgtm, but could we remove the reliance on tweetnacl-util entirely as recommended, by also porting the UTF8 encode/decode functions? issue should have been clearer, apologies.
Note that all encode/decode functions had to be swapped because the encode/decode function signatures for StableLib are the opposite of those in tweetnacl-util.
mantariksh
force-pushed
the
base64-stablelib
branch
from
d8dad83
to
7264f91
Compare
liangyuanruo
approved these changes
May 29, 2020
liangyuanruo
added a commit
that referenced
this pull request
Jun 4, 2020
This reverts commit 2dbce2d.
liangyuanruo
added a commit
that referenced
this pull request
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
encode/decodeBase64andencode/decodeUTF8fromtweetnacl-utilare unstable for large payloads.Closes #26
Solution
Use
encodeanddecodefrom StableLib instead. Note that for UTF8, all theencode/decodefunctions had to be swapped because the function signatures in StableLib are the opposite of those in tweetnacl-util.