refactor: update verification HOF to Verification class #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshadali172
requested changes
Jun 10, 2020
arshadali172
approved these changes
Jun 10, 2020
liangyuanruo
approved these changes
Jun 11, 2020
karrui
force-pushed
the
feat/class-based-verification
branch
from
1e9a7e7
to
19ae799
Compare
karrui
force-pushed
the
feat/class-based-crypto
branch
from
b62a828
to
8ce86a5
Compare
* test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
karrui
force-pushed
the
feat/class-based-verification
branch
from
19ae799
to
b46501b
Compare
liangyuanruo
pushed a commit
that referenced
this pull request
Jan 27, 2021
* fix(errors): remove typo in error messages * refactor: move separate verification functions into utils file * refactor: move verification publicKey retrieval into publicKey util * feat: rewrite verification.ts functions as Verification class * refactor: use Verification class in package init * test: add verification/utils tests * test: rewrite verification tests to use new Verification class * feat: add check for malformed auth payload * test: add tests for new package initialisation (#39) * test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
This was referenced Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly bigger undertaking than the other two classes due to the spread of functions.
This PR creates a new Verification class that only exposes the functions that provides:
authenticategenerateSignature.This does not change the current behavior of the application.
Various utilities used by the class has been moved to the
verification/utils.tshelper file.Part three of the refactor, meant to keep the PR size manageable.
Related to #31
Note that this PR is pointing to part 2: crypto class refactor
The current chain is:
master -> webhooks -> crypto -> verification (this)