Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use mode init parameter again #52

Merged
merged 8 commits into from
Feb 22, 2021
Merged

ref: use mode init parameter again #52

merged 8 commits into from
Feb 22, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Feb 18, 2021

This PR builds on #34, #36, #38 but removed the publicKey parameter after extensive discussion with @liangyuanruo

Reasons for removal

  1. Allowing users to update their public keys as an environment variable wouldn't have worked seamlessly anyways in the event of a private key leak, and would require users to be disseminated new public keys and to use the new public keys.

Would be easier to actually update the sdk and make users update??

@karrui
Copy link
Contributor Author

karrui commented Feb 18, 2021

@liangyuanruo i've tested it on local with this commit, all works as they should.

src/index.ts Outdated Show resolved Hide resolved
@karrui karrui merged commit 1d6f76a into develop Feb 22, 2021
@karrui karrui deleted the feat/keep-mode branch February 22, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants