-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release v0.9.0 - webhook attachments, linting, GitHub Actions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: merge Release 0.8.4 back to develop branch
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…chments (#62) * add downloadAndDecryptAttachments for downloading and decrypting attachments * add more tests to improve coverage * Update src/crypto.ts Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com> * update code per comments * add a backtick to readme.md * address comments by @seaerchin and @mantariksh * update types in README.md * remove extraneous http status check * remove type annotations in readme.md Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Adding eslint functionality * remove globals
* refactor(crypto): minor refactor of decryptWithAttachments * refactor(crypto): removed custom error in favour of returning null * refactor(util/crypto): fixed docs and changed method name * refactor(src/crypto): assigned promise to variable to reduce nesting; removed unused error in docs * docs(crypto): add docs * refactor(crypto): updated to avoid .then() chain * fix(crypto): removed unused import * refactor(crypto): added custom error for decryption failure * test(utils): adds unit tests for areAttachmentFieldIdsValid * style(util/spec): updated constants to use Object.keys * chore(errors): removed setting prototype explicitly * style(crypto): removed mixing of promise chaining and async/await Co-authored-by: seaerchin <jer005@e.ntu.edu.sg>
- make `test-ci` not run coverage, since that will be done by Actions - rename `test:watch` to `test-watch` for consistency, since gulp-style script names (ie, using `:`) are deprecated
* docs: specify version for attachment functionality * docs: collapse code examples into one * docs: use HAS_ATTACHMENTS to distinguish decrypt functions * chore: lint README * docs: fix typo
* build: add separate keypairs for dev environment * fix: use nacl.sign instead of nacl.box for keygen * docs: add comment specifying keygen function * docs: specify library of keygen function * test: add tests for key length
b2d0fad
to
32111b1
Compare
yong-jie
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Improved
Dev changes