Fix fetchStandardFontData warning #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a document that attempts to reach a new font file from the standard font path, it throws a warning: ``` Warning: fetchStandardFontData: failed to fetch file "FoxitSans.pfb" with "UnknownErrorException: The standard font "baseUrl" parameter must be specified, ensure that the "standardFontDataUrl" API parameter is provided.". ``` This automatically passes in the standardFontDataUrl path with the default path of the pdfjs-dist package. A thought had occurred to pass this in via argument but it's already very verbose and this path should be standard across most machines using pdf2md.
10ego
changed the title
LoneRifle
reviewed
Jul 26, 2023
Merged
|
Sorry to get back on this so late but your update is missing a trailing slash. Unfortunately I couldn't update it to this PR since it's already merged so I opened a new PR #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What problem are you trying to solve? What issue does this close?
When parsing a document that attempts to reach a new font file from the standard font path, it throws a warning:
This warning is thrown for every document that is being parsed with every font file it cannot use so when executed with a
--recursiveparameter this can flood the terminal. For e.g.:Solution
How did you solve the problem?
Bug Fixes:
This automatically passes in the standardFontDataUrl path with the default path of the pdfjs-dist package. A thought had occurred to pass this in via argument but it's already verbose enough and this path should be standard across most machines using pdf2md.
Before & After Screenshots
BEFORE:
Following console warning is thrown
Warning: fetchStandardFontData: failed to fetch file "FoxitSans.pfb" with "UnknownErrorException: The standard font "baseUrl" parameter must be specified, ensure that the "standardFontDataUrl" API parameter is provided.".AFTER:
No more console warnings