Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added to #67 #71

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Added to #67 #71

merged 2 commits into from
Sep 11, 2023

Conversation

10ego
Copy link

@10ego 10ego commented Aug 25, 2023

Fixes missing / in patch for #67.

@10ego
Fix path to fonts folder
6882be9 
The fix was missing a trailing slash
@10ego 10ego mentioned this pull request Aug 25, 2023
Merged
@10ego
handle trailing slash
6a622bf 
// path.resolve throws out trailing `/` so it must be added back
@10ego
Copy link
Author

10ego commented Aug 25, 2023

path.resolve throws out trailing / so it must be added back in. Rather than doing a + '/', I opted to use the path.join() for a more graceful handling of the path resolution in case things get hairy between potential local environment differences.

LoneRifle
LoneRifle approved these changes Sep 11, 2023
View reviewed changes
Copy link

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@10ego sflr, let me get this merged in now

@LoneRifle LoneRifle merged commit 9e7206e into opengovsg:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@10ego @LoneRifle