-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-269: add general ui fixes #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnantboy
reviewed
Jun 18, 2024
pregnantboy
reviewed
Jun 18, 2024
packages/frontend/src/pages/Tile/components/TableFooter/DeleteRowsButton.tsx
Outdated
Show resolved
Hide resolved
pregnantboy
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, otherwise lgtm
pregnantboy
added a commit
that referenced
this pull request
Jun 19, 2024
This reverts commit 35e0ce3.
6 tasks
m0nggh
added a commit
that referenced
this pull request
Jun 24, 2024
Refer to this #591 ## Problem Inconsistencies in our Plumber UI TODO: - [x] Check that dropdown for set up trigger looks ok after adding the `SingleSelect` dropdown PRs Extra fix: - [x] Check that chakra collapse doesn't hide itself e.g. in postman step when scrolling down ## Details - Standardise Test step + setup action button with ogp ds - Adjust context menus icons etc. - Standardise Alert Dialog texts - Delete button color schemes change to critical - Fix border radius for flow step - Standardise UI for tiles page ## Tests - [x] Still can delete and duplicate pipe - [x] Still can delete tile - [x] Still can delete column - [x] Still can test step with old and new pipes ## Screenshots Before https://github.com/opengovsg/plumber/assets/65110268/fc2a48b5-f051-440b-8e90-f6c18191e281 After https://github.com/opengovsg/plumber/assets/65110268/43ff982b-c3e8-4392-a9a5-cd4c0da2cee8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Inconsistencies in our Plumber UI
TODO:
SingleSelect
dropdown PRsDetails
Tests
Screenshots
Before
Screen.Recording.2024-05-24.at.12.27.17.PM.mov
After
Screen.Recording.2024-05-24.at.12.29.12.PM.mov