Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLU-269: add general ui fixes #591

Merged
merged 4 commits into from
Jun 19, 2024
Merged

PLU-269: add general ui fixes #591

merged 4 commits into from
Jun 19, 2024

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented May 24, 2024 •
edited

Problem

Inconsistencies in our Plumber UI
TODO:

  • Check that dropdown for set up trigger looks ok after adding the SingleSelect dropdown PRs

Details

  • Standardise Test step + setup action button with ogp ds
  • Adjust context menus icons etc.
  • Standardise Alert Dialog texts
  • Delete button color schemes change to critical
  • Fix border radius for flow step
  • Standardise UI for tiles page

Tests

  • Still can delete and duplicate pipe
  • Still can delete tile
  • Still can delete column
  • Still can test step with old and new pipes

Screenshots

Before

Screen.Recording.2024-05-24.at.12.27.17.PM.mov

After

Screen.Recording.2024-05-24.at.12.29.12.PM.mov

@linear Linear
Copy link

linear bot commented May 24, 2024

PLU-269 General ui fixes

@m0nggh m0nggh marked this pull request as ready for review June 18, 2024 03:44
@m0nggh m0nggh requested a review from a team June 18, 2024 03:44
pregnantboy
pregnantboy approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, otherwise lgtm

@m0nggh m0nggh merged commit 35e0ce3 into develop-v2 Jun 19, 2024
6 checks passed
@m0nggh m0nggh deleted the chore/general-ui-fixes branch June 19, 2024 03:13
pregnantboy added a commit that referenced this pull request Jun 19, 2024
@pregnantboy
Revert "PLU-269: add general ui fixes (#591)"
5e5d60e 
This reverts commit 35e0ce3.
@m0nggh m0nggh mentioned this pull request Jun 21, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnantboy pregnantboy pregnantboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m0nggh @pregnantboy