Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add general ui changes back after revert + fix #638

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Jun 21, 2024

Refer to this #591

Problem

Inconsistencies in our Plumber UI
TODO:

  • Check that dropdown for set up trigger looks ok after adding the SingleSelect dropdown PRs

Extra fix:

  • Check that chakra collapse doesn't hide itself e.g. in postman step when scrolling down

Details

  • Standardise Test step + setup action button with ogp ds
  • Adjust context menus icons etc.
  • Standardise Alert Dialog texts
  • Delete button color schemes change to critical
  • Fix border radius for flow step
  • Standardise UI for tiles page

Tests

  • Still can delete and duplicate pipe
  • Still can delete tile
  • Still can delete column
  • Still can test step with old and new pipes

Screenshots

Before

Screen.Recording.2024-05-24.at.12.27.17.PM.mov

After

Screen.Recording.2024-05-24.at.12.29.12.PM.mov

@graphite-app graphite-app bot requested a review from a team June 21, 2024 04:48
Copy link

graphite-app bot commented Jun 21, 2024

Graphite Automations

"Auto-assign Reviewers" took an action on this PR • (06/21/24)

1 reviewer was added to this PR based on Ian Chen's automation.

Copy link
Contributor

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, e2e fix works

Copy link
Contributor Author

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks sir

@m0nggh m0nggh merged commit 10efa35 into develop-v2 Jun 24, 2024
9 checks passed
@m0nggh m0nggh deleted the chore/add-general-ui-fixes branch June 24, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants