Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor msg template components; add telegram character limit #1148

Merged
merged 7 commits into from
May 5, 2021
Merged

feat: refactor msg template components; add telegram character limit #1148

merged 7 commits into from
May 5, 2021

Commits on May 3, 2021

  1. refactor: move common body template code to a separate component

    @zwliew
    zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    41a0e19 View commit details
    Browse the repository at this point in the history

  2. feat: support character count error thresholds; add telegram limit 

    Features:
* Disable the next button when the body lengh is greater than the error
  limit
* Define a warning threshold of 3000 chars and an error threshold of
  4096 chars for Telegram (4096 chars is the char limit for Telegram)
    @zwliew
    zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    5257b18 View commit details
    Browse the repository at this point in the history

  3. refactor: move styles into BodyTemplate.module.scss

    @zwliew
    zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    a155679 View commit details
    Browse the repository at this point in the history

  4. refactor: move component definition into BodyTemplate.tsx

    @lamkeewei @zwliew
    lamkeewei authored and zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9b6f083 View commit details
    Browse the repository at this point in the history

  5. refactor: tighten type definition for setActiveStep

    @lamkeewei @zwliew
    lamkeewei authored and zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b4ffb91 View commit details
    Browse the repository at this point in the history

  6. fix: pass saveTemplate as a prop to BodyTemplate

    @zwliew
    zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    fecd93c View commit details
    Browse the repository at this point in the history

  7. refactor: add tests for BodyTemplate

    @zwliew
    zwliew committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9cc7c23 View commit details
    Browse the repository at this point in the history