Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homeconnect] Adding the response code in the UI popup displaying the request details #10695

Closed
lolodomo opened this issue May 15, 2021 · 6 comments
Assignees
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@lolodomo
Copy link
Contributor

Even if it is of course a very minor enhancement, I think it would be cool to add the response code in the popup displayed when clicking on "Details" button of an API request in the UI page of the binding.

@bruestel : WDYT ?

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 15, 2021
@lolodomo
Copy link
Contributor Author

lolodomo commented May 16, 2021

Additionally, it could be even useful to display the response code when you run a request from the specific binding UI page.
I mean in this UI popup:
image
You can get the response code but you have to switch to the "API requests" table and look for your request (normally the last one).

@bruestel
Copy link
Contributor

Good idea, should be easy to implement. Will do it.

@lolodomo
Copy link
Contributor Author

@bruestel : do you plan to implement it? I am sure it would be easy for you than for me,

@bruestel
Copy link
Contributor

Added it to the modal.

Bildschirmfoto-20210629153809-1036x157

@bruestel
Copy link
Contributor

@lolodomo

Additionally, it could be even useful to display the response code when you run a request from the specific binding UI page.
I mean in this UI popup:

I've had a second look. I wouldn't show the response code for these kind of actions.

  1. if something went wrong the user can see the status code in the response body
  2. a big refactoring of the current controllers and api methods is required

fwolter pushed a commit that referenced this issue Jul 6, 2021
…cleanup (#10695) (#10914)

Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 6, 2021

PR enhancing that is merged.

@lolodomo lolodomo closed this as completed Jul 6, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this issue Jul 13, 2021
…cleanup (openhab#10695) (openhab#10914)

Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this issue Oct 26, 2021
…cleanup (openhab#10695) (openhab#10914)

Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
…cleanup (openhab#10695) (openhab#10914)

Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
…cleanup (openhab#10695) (openhab#10914)

Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

2 participants