Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulseaudio] The pulseaudio audio sink cannot play some audio format #11630

Closed
dalgwen opened this issue Nov 22, 2021 · 3 comments · Fixed by #11631
Closed

[pulseaudio] The pulseaudio audio sink cannot play some audio format #11630

dalgwen opened this issue Nov 22, 2021 · 3 comments · Fixed by #11631
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@dalgwen
Copy link
Contributor

dalgwen commented Nov 22, 2021

Expected Behavior

Pulseaudio sink should be able to play every PCM and MP3 audio formats.

Current Behavior

The pulseaudio sink outputs random high pitched noises when I submit PCM or MP3 sound not in the exact supported format (which is 16 bits PCM, 44100 hz and 2 channels)

Possible Solution

Add a pass to convert sound to the right format.
I will submit a pull request in a few minutes after the creation of this issue.

Steps to Reproduce (for Bugs)

Play a wav with the "wrong" format (for example, the output of the pico2wave TTS service in openHAB) through a pulseaudio audio sink.

Context

I was trying to use pico2wave TTS throught the pulseaudio binding.

Your Environment

  • openHAB 3.1.0
  • Java 11:
  • Debian buster
@dalgwen dalgwen added the bug An unexpected problem or unintended behavior of an add-on label Nov 22, 2021
dalgwen pushed a commit to dalgwen/openhab-addons that referenced this issue Nov 22, 2021
[pulseaudio] Add reencoding to play more audio formats (openhab#11630)
a3c85bd 
Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
@dalgwen dalgwen mentioned this issue Nov 22, 2021
Merged
dalgwen pushed a commit to dalgwen/openhab-addons that referenced this issue Nov 24, 2021
[pulseaudio] Add reencoding to play more audio formats (openhab#11630)
58ba87d 
Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/pulseaudio-as-sink-is-playing-back-way-to-fast/129349/2

This was referenced Dec 3, 2021
Closed
Closed
@Dracrius
Copy link

Dracrius commented Dec 3, 2021

#11662 This was also related to this bug. The new pull request snapshot solved it https://github.com/dalgwen/openhab-addons/releases/tag/3.2.0-SNAPSHOT_pulseaudio_11630

@Dracrius Dracrius mentioned this issue Dec 3, 2021
Closed
lolodomo pushed a commit that referenced this issue Dec 11, 2021
@dalgwen
[pulseaudio] Add reencoding to play more audio formats (#11630) (#11631)
374a89a 
Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
@dalgwen dalgwen mentioned this issue Dec 28, 2021
Closed
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
@dalgwen @NickWaterton
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
361de49 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this issue Jan 9, 2022
@dalgwen @mischmidt83
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
e5fb5c6 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
@dalgwen
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
695de31 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/pulseaudio-openhab-3-2-0-pulseaudio-raop-sinks-do-not-support-playback-other-than-16le-2ch-44-1khz/134756/2

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
@dalgwen
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
7bd56a3 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this issue Nov 6, 2022
@dalgwen @andan67
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
0e51cb4 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this issue Nov 12, 2022
@dalgwen @andrasU
[pulseaudio] Add reencoding to play more audio formats (openhab#11630) (
311ba09 
openhab#11631)

Add a pass to reencode PCM sound in 16 bit, 44100 hz, 2 channels, before sending it to the pulseaudio audio sink.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pulseaudio] Add reencoding to play more audio formats dalgwen/openhab-addons
3 participants
@dalgwen @openhab-bot @Dracrius