Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Channel switch for washing machine should be ON when state is END #15619

Closed
jlaur opened this issue Sep 18, 2023 · 0 comments · Fixed by #15620
Closed

[miele] Channel switch for washing machine should be ON when state is END #15619

jlaur opened this issue Sep 18, 2023 · 0 comments · Fixed by #15620
Assignees
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@jlaur
Copy link
Contributor

jlaur commented Sep 18, 2023

The reason is that the washing machine needs to be stopped before it can be opened. This can be done by sending an OFF command to the switch channel. However, this is only possible if the state is already ON.

Therefore, state end should be treated the same way as running for dishwashers, tumble dryers and washing machines. State rinse hold can be added as well, as I would assume this phase can also be interrupted similarly.

This further refines #13069 having a wrong assumption that switch -> off would not do anything for state end:

So states where it makes sense to update switch to off: STATE_WAITING_TO_START (because on will then start), STATE_PAUSED. And to on: STATE_RUNNING (because off will then stop). For all other states it doesn't really matter as trigger will not work.

Your Environment

  • Version used: 4.0.3
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 18, 2023
@jlaur jlaur self-assigned this Sep 18, 2023
jlaur added a commit to jlaur/openhab-addons that referenced this issue Sep 18, 2023
Fixes openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur added a commit to jlaur/openhab-addons that referenced this issue Sep 18, 2023
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
lolodomo pushed a commit that referenced this issue Sep 23, 2023
Resolves #15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this issue Sep 29, 2023
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this issue Oct 13, 2023
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this issue Oct 21, 2023
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this issue Oct 29, 2023
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
Resolves openhab#15619

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant