Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Add information/failure channels #16463

Merged
merged 1 commit into from Mar 3, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Feb 26, 2024

This adds two new advanced channels to signal information or failure.

Unfortunately the API does not provide any more details, so the appliance must be checked manually.

However, this can still be used to draw attention (e.g. send a notification to phone or voice announcement to audio sink). Also, it can be used to avoid taking any actions that would otherwise risk erasing the details on the appliance, for example unlocking the washing machine door by sending an OFF command to the switch channel when entering the laundry room (see #15619).

I observed this in my washing machine logs a few days ago after presumably adding too much washing liquid:

    {
     "Name": "signalInfo",
     "Value": true,
     "Polling": 0,
     "Metadata": {
      "Filter": "true",
      "description": "Signal Info",
      "LocalizedID": "Information",
      "LocalizedValue": "",
      "access": "RE"
     }

@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Feb 26, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Feb 26, 2024

I would like to test this for some time, therefore initially publishing as a draft.

I was able to test this with much quicker feedback by opening the fridge door for too long. 😄

2024-02-26 22:33:51.722 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Fridge_Door' changed from CLOSED to OPEN
2024-02-26 22:35:56.377 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Fridge_Failure' changed from OFF to ON

@jlaur jlaur removed the work in progress A PR that is not yet ready to be merged label Feb 26, 2024
@jlaur jlaur marked this pull request as ready for review February 26, 2024 21:48
@jlaur jlaur requested a review from kgoderis as a code owner February 26, 2024 21:50
@jlaur jlaur requested a review from a team March 2, 2024 15:45
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, LGTM

@lsiepel lsiepel merged commit 53694df into openhab:main Mar 3, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Mar 3, 2024
@jlaur jlaur deleted the miele-info-failure branch March 3, 2024 11:52
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants