Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] OH 4.1.0 KNX binding fails to send updates to contact-control items #16115

Closed
tkuehne71 opened this issue Dec 26, 2023 · 5 comments · Fixed by #16263
Closed

[knx] OH 4.1.0 KNX binding fails to send updates to contact-control items #16115

tkuehne71 opened this issue Dec 26, 2023 · 5 comments · Fixed by #16263
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@tkuehne71
Copy link

tkuehne71 commented Dec 26, 2023

See discussion and more detailed description over here: https://community.openhab.org/t/contact-knx-items-dont-seem-to-be-sent-with-oh-4-1-0/152298

It seems that beginning with 4.1.0 the KNX binding fails to send updates to contact-control items.

That is the case regardless if the items get updated using the postUpdate method or if the updates are supposed to happen via channel-linking through items that get updated via another binding's channel.

@tkuehne71 tkuehne71 added the bug An unexpected problem or unintended behavior of an add-on label Dec 26, 2023
@J-N-K
Copy link
Member

J-N-K commented Dec 26, 2023

@holgerfriedrich Can you have a look?

@holgerfriedrich
Copy link
Member

I will have a look.

Btw: the link above does not work for me unless I copy the link text.... Could you pls check?

@lolodomo lolodomo changed the title OH 4.1.0 KNX binding fails to send updates to contact-control items [knx] OH 4.1.0 KNX binding fails to send updates to contact-control items Dec 28, 2023
@tkuehne71
Copy link
Author

The issue with the link seems to be fixed. Thanks, jlaur.

At least one other person has reported a similar issue with their setup in the thread.

Best,

Tom

@holgerfriedrich
Copy link
Member

Lets first look at switch for comparison:
Things of type switch and switch-control send to KNX when sendCommand() is called, and switch-control also on postUpdate(). If I set profile=follow on the item for switch, it responds to postUpdate() as well.
For me this looks like expected behavior.

For things of type contact and contact-control, the framework forbids sendCommand() with values OPEN or CLOSED, only REFRESH is allowed. postUpdate() does not send to the bus for contact.
This is also what I would expect.

=> What seems to be missing, is sending to KNX on postUpdate() for contact-control.

@J-N-K I think I need you help on this. I just do not see the missing piece, can you point me the the place where the binding registers for to data from postUpdate? Or is core at them moment preventing this data to be sent to the binding for contact?

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/contact-knx-items-dont-seem-to-be-sent-with-oh-4-1-0/152298/16

holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Jan 12, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Jan 12, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Jan 12, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Jan 26, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
kaikreuzer pushed a commit that referenced this issue Jan 28, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes #16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants