[knx] postUpdate for contact-control sends to bus #16263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is the most elegant way to solve the problem. |
holgerfriedrich
force-pushed
the
pr-knx-contact-control
branch
from
05ccdf3
to
4b0918d
Compare
holgerfriedrich
added
the
bug
holgerfriedrich
force-pushed
the
pr-knx-contact-control
branch
from
4b0918d
to
0521b5c
Compare
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device. * Add a new profile for contact-control items * Add a profile factory and a profile advisor class * Handle postUpdate like a command and send message on KNX bus Fixes openhab#16115. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-knx-contact-control
branch
from
0521b5c
to
7845a6c
Compare
kaikreuzer
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Somehow looks like a huge workaround, but I wouldn't have any better suggestion how to address the issue.
@J-N-K Any thoughts from your side? Shall we merge it like this?
|
I don't know any better implementation. I think openhab/openhab-core#2578 is a similar issue where we need a solution for sending something in to the outside world that is only acceptation updates, not commands. My suggestion would be to merge here and discuss the " |
|
Thanks for your input - so let's merge then! |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device. * Add a new profile for contact-control items * Add a profile factory and a profile advisor class * Handle postUpdate like a command and send message on KNX bus Fixes openhab#16115. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device.
Fixes #16115.