Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wundergroundupdatereceiver] Initial contribution #10105

Merged
merged 18 commits into from
Jun 19, 2022

Conversation

danieldemus
Copy link
Contributor

@danieldemus danieldemus commented Feb 8, 2021

Signed-off-by: Daniel Demus daniel-github@demus.dk

Being the owner of a weather station that is able to submit measurements to wunderground.com via the update URL, I looked for a binding to capture the values and use them locally on my openhab instance to fx. open and close windows or awnings depending on weather conditions, or just to display current weather on a weather page.

I couldn't find any thus this binding. It registers a servlet listening on the wunderground.com update URL path and gathers the submitted values into channels on the thing. Multiple wunderground accounts can be supported by configuring the station id of the thing. The station id must match the ID parameter in the requests from the weather station. Every update is also passed along in a trigger channel, which can then resend the update to wunderground.com in a trivial rule script. In addition you can also submit measurements to other weather services in whatever format they accept.

The build artifact can be found here:
https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.wundergroundupdatereceiver/3.2.0-SNAPSHOT/

@danieldemus danieldemus requested a review from a team as a code owner February 8, 2021 15:48
@Hilbrand Hilbrand added the new binding If someone has started to work on a binding. For a new binding PR. label Feb 8, 2021
@danieldemus danieldemus force-pushed the initial_implementation branch 5 times, most recently from 0421ec4 to 3f21be9 Compare February 26, 2021 07:36
@danieldemus danieldemus requested review from Skinah and removed request for a team February 28, 2021 18:07
danieldemus and others added 9 commits June 19, 2022 15:30
Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f
To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@fwolter fwolter merged commit 56f4c89 into openhab:main Jun 19, 2022
@fwolter fwolter added this to the 3.3 milestone Jun 19, 2022
@fwolter
Copy link
Member

fwolter commented Jun 19, 2022

@jlaur Could you review the danish translation and load it into Crowdin?

@fwolter
Copy link
Member

fwolter commented Jun 19, 2022

@kaikreuzer Can you invite @danieldemus to the contributors?

@danieldemus danieldemus deleted the initial_implementation branch June 19, 2022 15:45
@jlaur
Copy link
Contributor

jlaur commented Jun 19, 2022

Could you review the danish translation and load it into Crowdin?

Yes, although in the opposite order since now merged. :-)

@jlaur
Copy link
Contributor

jlaur commented Jun 19, 2022

Could you review the danish translation and load it into Crowdin?

Yes, although in the opposite order since now merged. :-)

@fwolter, @danieldemus - I have now done first review walk-through:

  • 160 words are missing translation.
  • I found a number of mistakes like swapped label/description, missing units, missing description, etc. I have posted comments for each of them.
  • Some obvious mistakes like typos, bad grammar, missing punctuation etc. I have fixed myself.
  • All the rest of the strings have been approved.

@danieldemus - please have a look at the comments and missing translations in Crowdin:
https://crowdin.com/translate/openhab-addons/6234/en-da?filter=basic&value=3

Since the Danish strings were merged directly into the codebase with this PR, the identified mistakes will be present in 3.3 unless all missing strings are provided and mistakes corrected before then. This is because the synchronization back to the repository is only triggered when 100% strings are provided and approved.

@jlaur
Copy link
Contributor

jlaur commented Jun 20, 2022

@danieldemus - I went through another round, please have another look at Crowdin to fix the last few translations.

Will you create a PR for fixing the default string issues? At least this, don't remember if there are more:

(actually outdoor)

channel-type.wundergroundupdatereceiver.humidity.label = Humidity
channel-type.wundergroundupdatereceiver.humidity.description = Humidity in %.

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* [wundergroundupdatereceiver] Initial implementation

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Code review

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Fix some description formatting

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add some more channel types per request

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add more headers to response



Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Based on the observed headers from actual traffic to wunderground.com.

* [wundergroundupdatereceiver] Discovery service

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Upgrade to 3.2, fix group name constants

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add a list of channel types

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add dateutc as synthetic DateTime channel

Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Do more programmatic configuration

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] More readme

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Update copyright year

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Handle multiple instance request parameters

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f

* [wundergroundupdatereceiver] Add unmapped but mappable channels

To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Don't pass superfluous config to channels

Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add generated i18n file

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-case test method names

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-word thing file section of README

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

Co-authored-by: Daniel Demus <dde@nine.dk>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [wundergroundupdatereceiver] Initial implementation

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Code review

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Fix some description formatting

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add some more channel types per request

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add more headers to response



Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Based on the observed headers from actual traffic to wunderground.com.

* [wundergroundupdatereceiver] Discovery service

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Upgrade to 3.2, fix group name constants

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add a list of channel types

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add dateutc as synthetic DateTime channel

Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Do more programmatic configuration

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] More readme

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Update copyright year

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Handle multiple instance request parameters

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f

* [wundergroundupdatereceiver] Add unmapped but mappable channels

To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Don't pass superfluous config to channels

Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add generated i18n file

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-case test method names

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-word thing file section of README

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

Co-authored-by: Daniel Demus <dde@nine.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [wundergroundupdatereceiver] Initial implementation

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Code review

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Fix some description formatting

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add some more channel types per request

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add more headers to response



Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Based on the observed headers from actual traffic to wunderground.com.

* [wundergroundupdatereceiver] Discovery service

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Upgrade to 3.2, fix group name constants

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add a list of channel types

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add dateutc as synthetic DateTime channel

Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Do more programmatic configuration

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] More readme

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Update copyright year

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Handle multiple instance request parameters

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f

* [wundergroundupdatereceiver] Add unmapped but mappable channels

To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Don't pass superfluous config to channels

Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add generated i18n file

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-case test method names

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-word thing file section of README

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

Co-authored-by: Daniel Demus <dde@nine.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [wundergroundupdatereceiver] Initial implementation

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Code review

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Fix some description formatting

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add some more channel types per request

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add more headers to response



Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Based on the observed headers from actual traffic to wunderground.com.

* [wundergroundupdatereceiver] Discovery service

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Upgrade to 3.2, fix group name constants

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add a list of channel types

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add dateutc as synthetic DateTime channel

Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Do more programmatic configuration

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] More readme

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Update copyright year

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Handle multiple instance request parameters

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f

* [wundergroundupdatereceiver] Add unmapped but mappable channels

To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Don't pass superfluous config to channels

Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add generated i18n file

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-case test method names

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-word thing file section of README

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

Co-authored-by: Daniel Demus <dde@nine.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [wundergroundupdatereceiver] Initial implementation

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Code review

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Fix some description formatting

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add some more channel types per request

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add more headers to response



Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Based on the observed headers from actual traffic to wunderground.com.

* [wundergroundupdatereceiver] Discovery service

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Upgrade to 3.2, fix group name constants

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add a list of channel types

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add dateutc as synthetic DateTime channel

Also add som emore constants
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Do more programmatic configuration

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] More readme

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Update copyright year

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Handle multiple instance request parameters

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Ie. those that can have an index number in the name, fx. temp1f, temp2f

* [wundergroundupdatereceiver] Add unmapped but mappable channels

To support multiple devices any new parameters that are submitted cause a new channel to be created
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Don't pass superfluous config to channels

Also documentation additions
Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Add generated i18n file

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-case test method names

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

* [wundergroundupdatereceiver] Re-word thing file section of README

Signed-off-by: Daniel Demus <daniel-github@demus.dk>

Co-authored-by: Daniel Demus <dde@nine.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet