Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wundergroundupdatereceiver] Bugfix: Check whether the thing is managed before adding newly discovered parameters as channels. #12998

Conversation

danieldemus
Copy link
Contributor

@danieldemus danieldemus commented Jun 23, 2022

Description

Fixes #12997

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jun 24, 2022
@jlaur
Copy link
Contributor

jlaur commented Jun 24, 2022

@fwolter - would it be possible for you to review this in time for 3.3, since you did the review of #10105?

@jlaur jlaur requested a review from fwolter June 24, 2022 10:17
@fwolter
Copy link
Member

fwolter commented Jun 24, 2022

If you just need to check if a Thing exists, ThingRegistry seems to be more suitable.

@danieldemus
Copy link
Contributor Author

If you just need to check if a Thing exists, ThingRegistry seems to be more suitable.

I need to know whether it's configured in a file or the UI. This is how the rest api finds out whether the thing is editable. It comes from here: ThingResource.java::725. It might be an idea to add a property such as isEditable to Thing.

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM

@fwolter fwolter merged commit ccbc6a8 into openhab:main Jun 24, 2022
@danieldemus danieldemus deleted the 12997-wundergroundreciever-adds-unwanted-channels branch June 24, 2022 17:04
@wborn wborn added this to the 3.3 milestone Jun 26, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…hab#12998)

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…hab#12998)

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…hab#12998)

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…hab#12998)

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…hab#12998)

Ie. created in the UI or by discovery
Signed-off-by: Daniel Demus <daniel-github@demus.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wundergroundupdatereceiver] The binding adds autodiscovered channels even on things defined in files
4 participants