Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] Cleanup workaround leftovers and fix a few SAT findings #10670

Merged
merged 1 commit into from
May 12, 2021
Merged

[modbus] Cleanup workaround leftovers and fix a few SAT findings #10670

merged 1 commit into from
May 12, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented May 11, 2021

@wborn
[modbus] Cleanup workaround leftovers and fix a few SAT findings
f61d087 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested review from ssalonen and a team May 11, 2021 11:30
@wborn wborn mentioned this pull request May 11, 2021
Merged
@ssalonen
Copy link
Contributor

Thanks @wborn ! Lgtm if tests pass

@cweitkamp cweitkamp added this to the 3.1 milestone May 12, 2021
cweitkamp
cweitkamp approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 183fb0e into openhab:main May 12, 2021
@cweitkamp cweitkamp added the test label May 12, 2021
@wborn wborn deleted the modbus-cleanup branch May 12, 2021 11:18
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@wborn @computergeek1507
[modbus] Cleanup workaround leftovers and fix a few SAT findings (ope…
56d1588 
…nhab#10670)

- Cleanup workaround leftovers and fix a few SAT findings

Signed-off-by: Wouter Born <github@maindrain.net>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@wborn @frederictobiasc
[modbus] Cleanup workaround leftovers and fix a few SAT findings (ope…
a1ad14a 
…nhab#10670)

- Cleanup workaround leftovers and fix a few SAT findings

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@wborn @thinkingstone
[modbus] Cleanup workaround leftovers and fix a few SAT findings (ope…
5a09e16 
…nhab#10670)

- Cleanup workaround leftovers and fix a few SAT findings

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@wborn
[modbus] Cleanup workaround leftovers and fix a few SAT findings (ope…
6cf25c6 
…nhab#10670)

- Cleanup workaround leftovers and fix a few SAT findings

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@wborn @ssalonen @cweitkamp