Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resol] correct handling of system date/time field #10811

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Conversation

ramack
Copy link
Contributor

@ramack ramack commented Jun 5, 2021

Correct the handling of Date and Time fields in Packets on the VBUS to make these channels available and fix #10684

Further discussion is here: https://community.openhab.org/t/resol-binding-stopped-working-in-recent-nightly-builds/122371/7

There is a jar of the fixed binding here: https://github.com/ramack/openhab-addons/blob/resolReleases/bundles/org.openhab.binding.resol/target/org.openhab.binding.resol-3.1.0-SNAPSHOT.jar?raw=true

@EjvindHald confirmed the fix so we can merge this bugfix.

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
@ramack ramack changed the title [resol] [WIP] correct handling of system date/time field to close #10684 [resol] correct handling of system date/time field to close #10684 Jun 8, 2021
@fwolter fwolter changed the title [resol] correct handling of system date/time field to close #10684 [resol] correct handling of system date/time field Jun 12, 2021
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 72e3729 into openhab:main Jun 12, 2021
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jun 12, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 12, 2021
@ramack ramack deleted the merged branch June 12, 2021 21:00
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* correct handling of system date/time field to close openhab#10684

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>

* further fix

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resol binding in version 3.1 M4 not updating values
2 participants