Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tivo] Refresh persistent connection every 12 hours #10824

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

mlobstein
Copy link
Contributor

This PR fixes an issue with the Tivo binding while using the option to always keep the connection to the device open. The previous strategy was to keep the original socket connection open indefinitely. This works OK, but after several days the connection would die and the binding would not reconnect without restarting. Sometimes the device would not accept a new connection without being rebooted first. To alleviate these problems, the binding will now close and re-open the persistent connection every 12 hours .

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit bce5363 into openhab:main Jun 12, 2021
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jun 12, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 12, 2021
@mlobstein mlobstein deleted the tivo_refreshconnection branch June 12, 2021 18:27
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants