Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tivo] Fix thing staying offline after connection refresh #10902

Merged
merged 1 commit into from
Jul 6, 2021
Merged

[tivo] Fix thing staying offline after connection refresh #10902

merged 1 commit into from
Jul 6, 2021

Conversation

mlobstein
Copy link
Contributor

This PR is a follow-on to #10824. It was discovered that after the connection refresh, the thing was showing as offline even though the connection was working. Please merge prior to the OH 3.1.0 final release if possible. @kaikreuzer

@mlobstein
Fix thing staying offline after connection refresh
d6a52d5 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
fwolter
fwolter approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IMHO this should be merged before OH 3.1 is released. The impact on build stability and overall stability seems pretty low to me.

@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jun 27, 2021
@fwolter fwolter requested a review from kaikreuzer June 27, 2021 15:42
@martinvw martinvw added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 30, 2021
@fwolter fwolter merged commit 58f20c5 into openhab:main Jul 6, 2021
@fwolter fwolter added this to the 3.2 milestone Jul 6, 2021
@mlobstein mlobstein deleted the tivo_offlinefix branch July 7, 2021 02:30
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@mlobstein @computergeek1507
[tivo] Fix thing staying offline after connection refresh (openhab#10902
bd4ba6a 
)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@mlobstein @frederictobiasc
[tivo] Fix thing staying offline after connection refresh (openhab#10902
0a948ec 
)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@mlobstein @thinkingstone
[tivo] Fix thing staying offline after connection refresh (openhab#10902
c42f648 
)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@mlobstein
[tivo] Fix thing staying offline after connection refresh (openhab#10902
1b33f86 
)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlobstein @fwolter @martinvw