Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VigiCrues] Adding localization and a bit of code cleansing #10992

Merged
merged 2 commits into from
Jul 17, 2021
Merged

[VigiCrues] Adding localization and a bit of code cleansing #10992

merged 2 commits into from
Jul 17, 2021

Conversation

clinique
Copy link
Contributor

Signed-off-by: clinique gael@lhopital.org

@clinique
Adding localization and a bit of code cleansing.
14f5a0f 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo July 13, 2021 14:37
@clinique clinique self-assigned this Jul 13, 2021
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Jul 13, 2021
lolodomo
lolodomo requested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/i18n/vigicrues_fr.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/i18n/vigicrues_fr.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/i18n/vigicrues_fr.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.vigicrues/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@clinique
Review corrections
18c83af 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo July 14, 2021 08:19
lolodomo
lolodomo approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 15, 2021
fwolter
fwolter approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 71638ce into openhab:main Jul 17, 2021
@fwolter fwolter added this to the 3.2 milestone Jul 17, 2021
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@clinique @dw-8
[VigiCrues] Adding localization and a bit of code cleansing. (openhab…
92079d7 
…#10992)

* Adding localization and a bit of code cleansing.

Signed-off-by: clinique <gael@lhopital.org>

* Review corrections

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@dw-8
Revert "[VigiCrues] Adding localization and a bit of code cleansing. (o…
e1bf7d5 
…penhab#10992)"

This reverts commit 92079d7.
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@clinique @dw-8
[VigiCrues] Adding localization and a bit of code cleansing. (openhab…
abd236a 
…#10992)

* Adding localization and a bit of code cleansing.

Signed-off-by: clinique <gael@lhopital.org>

* Review corrections

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@dw-8
Revert "[VigiCrues] Adding localization and a bit of code cleansing. (o…
9b21be5 
…penhab#10992)"

This reverts commit 92079d7.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@clinique clinique deleted the Vigicrues branch October 13, 2021 10:41
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@clinique @frederictobiasc
[VigiCrues] Adding localization and a bit of code cleansing. (openhab…
b1ee118 
…#10992)

* Adding localization and a bit of code cleansing.

Signed-off-by: clinique <gael@lhopital.org>

* Review corrections

Signed-off-by: clinique <gael@lhopital.org>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@clinique @thinkingstone
[VigiCrues] Adding localization and a bit of code cleansing. (openhab…
871a061 
…#10992)

* Adding localization and a bit of code cleansing.

Signed-off-by: clinique <gael@lhopital.org>

* Review corrections

Signed-off-by: clinique <gael@lhopital.org>
@wborn wborn changed the title [VigiCrues] Adding localization and a bit of code cleansing. [VigiCrues] Adding localization and a bit of code cleansing Dec 18, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@clinique
[VigiCrues] Adding localization and a bit of code cleansing. (openhab…
9b32a94 
…#10992)

* Adding localization and a bit of code cleansing.

Signed-off-by: clinique <gael@lhopital.org>

* Review corrections

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@clinique @fwolter @lolodomo @kaikreuzer