Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] Upgrade bouncycastle dependencies from 1.51 to 1.72 #11104

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2021

Bumps bcprov-jdk15on from 1.51 to 1.67.

Changelog

Sourced from bcprov-jdk15on's changelog.

2.1.1 Version Release: 1.70 Date:      TBD

2.2.1 Version Release: 1.69 Date:      2021, June 7th.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from yfre as a code owner August 13, 2021 15:32
@dependabot dependabot bot added the awaiting external dependency Depends on a new version of an external dependency label Aug 13, 2021
@lolodomo
Copy link
Contributor

@andylintner @yfre : can you evaluate if a change of version is possible ?
The last version is even 1.70 dated December 2021
https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk15on

@wborn
Copy link
Member

wborn commented Mar 7, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/bundles/org.openhab.io.homekit/org.bouncycastle-bcprov-jdk15on-1.67 branch from 671ce9d to 1075fea Compare March 7, 2022 20:15
@dependabot dependabot bot requested a review from andylintner as a code owner March 7, 2022 20:15
@jlaur
Copy link
Contributor

jlaur commented May 27, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/bundles/org.openhab.io.homekit/org.bouncycastle-bcprov-jdk15on-1.67 branch from 1075fea to 139488b Compare May 27, 2022 20:08
@wborn wborn changed the title Bump bcprov-jdk15on from 1.51 to 1.67 in /bundles/org.openhab.io.homekit [homekit] Upgrade bcprov-jdk15on from 1.51 to 1.67 Oct 9, 2022
Bumps [bcprov-jdk15on](https://github.com/bcgit/bc-java) from 1.51 to 1.67.
- [Release notes](https://github.com/bcgit/bc-java/releases)
- [Changelog](https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bcprov-jdk15on
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@wborn
Copy link
Member

wborn commented Oct 12, 2022

Depends on hap-java/HAP-Java#169

@wborn wborn force-pushed the dependabot/maven/bundles/org.openhab.io.homekit/org.bouncycastle-bcprov-jdk15on-1.67 branch from 139488b to 8e7a14a Compare October 12, 2022 17:10
@wborn wborn changed the title [homekit] Upgrade bcprov-jdk15on from 1.51 to 1.67 [homekit] Upgrade bcprov-jdk15on from 1.51 to 1.70 Oct 12, 2022
@wborn wborn added enhancement An enhancement or new feature for an existing add-on security labels Oct 12, 2022
@wborn wborn changed the title [homekit] Upgrade bcprov-jdk15on from 1.51 to 1.70 [homekit] Upgrade bouncycastle from 1.51 to 1.70 Oct 12, 2022
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the dependabot/maven/bundles/org.openhab.io.homekit/org.bouncycastle-bcprov-jdk15on-1.67 branch from 8e7a14a to 213c9c4 Compare October 12, 2022 19:37
@wborn wborn changed the title [homekit] Upgrade bouncycastle from 1.51 to 1.70 [homekit] Upgrade bouncycastle dependencies from 1.51 to 1.72 Oct 12, 2022
@wborn
Copy link
Member

wborn commented Nov 5, 2022

This does not seem to work with HAP-Java, see also: hap-java/HAP-Java#169

@wborn wborn closed this Nov 5, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/bundles/org.openhab.io.homekit/org.bouncycastle-bcprov-jdk15on-1.67 branch November 5, 2022 09:26
@wborn wborn removed the awaiting external dependency Depends on a new version of an external dependency label Dec 23, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/io-jetty-certificate-embeds-bouncy-castle-crypto-classes-resulting-in-classloader-error/153020/5

@morph166955
Copy link
Contributor

@wborn just gave it a quick look. Suggest we try with BC 1.77 before troubleshooting any further to see if the problem is resolved. 1.72 is over a year old now so the chances a bug was fixed is decent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants