Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Fix reading of water/power consumption on some appliance models/configurations #11417

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 19, 2021

Fixes #11416

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Fix too strict validation of ExtendedDeviceState number of bytes.

Changed also to log too few bytes as warnings as this implies only that appliance doesn't provide enough information for channels to be supported/updated.

Fixes openhab#11416

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from kgoderis as a code owner October 19, 2021 17:46
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 20, 2021
@kaikreuzer kaikreuzer merged commit b893b07 into openhab:main Oct 21, 2021
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Oct 21, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Oct 21, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
…enhab#11417)

Fixes openhab#11416

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…enhab#11417)

Fixes openhab#11416

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@jlaur jlaur deleted the 11416-miele-extended-device-state-validation branch June 13, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miele] Error reading extended device state (water/power consumption) after service
3 participants