Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Fix logging for appliances where consumption data is not supported #12728

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 12, 2022

This is another iteration #11417 regarding extended device state.

A wrong assumption about the minimum amount of data being available in ExtendedDeviceState has been revealed after receiving data from an older appliance model.

Accordingly, logging has been fixed to more accurately describe this issue and log level has been reduced to DEBUG.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label May 12, 2022
@jlaur jlaur requested a review from kgoderis as a code owner May 12, 2022 21:04
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit cc43251 into openhab:main May 12, 2022
@lolodomo lolodomo added this to the 3.3 milestone May 12, 2022
@jlaur jlaur deleted the 11416-miele-extended-device-state-log-level branch May 25, 2022 21:04
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/anyone-still-using-the-miele-home-xgw-3000-binding/126975/11

andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…penhab#12728)

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants