Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbquery] JDBC database bridge #11428

Closed
wants to merge 5 commits into from
Closed

Conversation

lujop
Copy link
Contributor

@lujop lujop commented Oct 23, 2021

Introduce a Bridge to allow JDBC queries.

Implementation is nearly finished and it's working at my home device but needs some cleaning and documentation

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/error-using-multiple-features-with-optional-dependencies-in-addon/128078/1

@wborn wborn added work in progress A PR that is not yet ready to be merged enhancement An enhancement or new feature for an existing add-on labels Nov 27, 2021
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
@lujop lujop requested review from fwolter and Skinah January 7, 2022 20:56
@lujop lujop removed the work in progress A PR that is not yet ready to be merged label Jan 7, 2022
@lujop lujop changed the title [dbquery] JDBC database bridge [WIP] [dbquery] JDBC database bridge Jan 7, 2022
@lujop
Copy link
Contributor Author

lujop commented Jan 7, 2022

JDBC implementation is finished and ready for review

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/optional-dependency-not-available/127104/10

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/increase-openness-and-competition-on-components-developed-outside-the-official-source-code-repositories/135183/13

@jlaur jlaur requested a review from a team May 27, 2022 19:43
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and patience. I'm sorry you have not received any feedback after several months, and yet I don't have the expertise to assess all parts of this PR, especially the dependencies towards external libraries. I hope a more seasoned maintainer (ping @openhab/add-ons-maintainers) can step in and help. I must say that the code looks pretty good to me though.

- *MySQL* (with driver version 8.0.26)
- *Sqlite* (with driver version 3.16.1)

JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but please reformat to one sentence per line.

- *MySQL* (with driver version 8.0.26)
- *Sqlite* (with driver version 3.16.1)

JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases.
JDBC driver must be installed on your openHAB server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases.

- *Sqlite* (with driver version 3.16.1)

JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases.
If you need more than one driver you must install them manually from OpenHab console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you need more than one driver you must install them manually from OpenHab console.
If you need more than one driver you must install them manually from the openHAB console.

@@ -182,10 +212,12 @@ Example (using Jython script):

## Examples

### The Simplest case
### The Simplest case InfluxDB2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers also JDBC now, so why is InfluxDB2 added to chapter name?

@@ -0,0 +1 @@
Si la configuració de la bbdd és buida el item no es connecta pero el log es molt dolent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

@jlaur
Copy link
Contributor

jlaur commented Aug 1, 2022

@lujop - are you still interested in a review?

@lsiepel lsiepel added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Apr 29, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jul 8, 2024

As there has been no activity for over two years, I guess we cannot get this to the finish line. I close this PR for now. If ever needed it can be re-opened again.

@lsiepel lsiepel closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback enhancement An enhancement or new feature for an existing add-on stale As soon as a PR is marked stale, it can be removed 6 months later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants