-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbquery] JDBC database bridge #11428
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
d756cdd
to
1e31756
Compare
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
067bad2
to
42b5f72
Compare
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
JDBC implementation is finished and ready for review |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/optional-dependency-not-available/127104/10 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and patience. I'm sorry you have not received any feedback after several months, and yet I don't have the expertise to assess all parts of this PR, especially the dependencies towards external libraries. I hope a more seasoned maintainer (ping @openhab/add-ons-maintainers) can step in and help. I must say that the code looks pretty good to me though.
- *MySQL* (with driver version 8.0.26) | ||
- *Sqlite* (with driver version 3.16.1) | ||
|
||
JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but please reformat to one sentence per line.
- *MySQL* (with driver version 8.0.26) | ||
- *Sqlite* (with driver version 3.16.1) | ||
|
||
JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases. | |
JDBC driver must be installed on your openHAB server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases. |
- *Sqlite* (with driver version 3.16.1) | ||
|
||
JDBC driver must be installed in your OpenHab server. For convenience, if you only need one driver the addon provides several features with JDBC driver included for each of the previous databases. | ||
If you need more than one driver you must install them manually from OpenHab console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need more than one driver you must install them manually from OpenHab console. | |
If you need more than one driver you must install them manually from the openHAB console. |
@@ -182,10 +212,12 @@ Example (using Jython script): | |||
|
|||
## Examples | |||
|
|||
### The Simplest case | |||
### The Simplest case InfluxDB2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This covers also JDBC now, so why is InfluxDB2 added to chapter name?
@@ -0,0 +1 @@ | |||
Si la configuració de la bbdd és buida el item no es connecta pero el log es molt dolent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this.
@lujop - are you still interested in a review? |
As there has been no activity for over two years, I guess we cannot get this to the finish line. I close this PR for now. If ever needed it can be re-opened again. |
Introduce a Bridge to allow JDBC queries.
Implementation is nearly finished and it's working at my home device but needs some cleaning and documentation